Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Pagination error #2

Closed
marcos-borunda opened this Issue Feb 9, 2012 · 7 comments

Comments

Projects
None yet
4 participants

When you pass the itemPerPage attribute it works at first, but if you try to go to the next page it will show every element in the list, then if you keep going through pages it will take out "itemPerPage" elements.

p.s. Thanks for sharing this great code! my javascript/jQuery skills aren't that good that's why I wasn't able to contribute fixing it :S

Owner

taitems commented Sep 11, 2012

Hi, is there any chance this issue is still occurring? I just pushed an update that should resolve other paging issues. If not, I'll close this. Tait.

Collaborator

usmonster commented Jul 18, 2013

@marcos-borunda Can it be assumed that this has been fixed for you? If so, this issue can be closed. Thanks!

@usmonster I haven't tested new releases. At the moment I don't have time to check, but let me test it this weekend and I'll let you know.

Collaborator

usmonster commented Nov 6, 2013

@marcos-borunda I'll assume this issue has been resolved and close it, but feel free to comment here if that's not the case and it can be reopened. Thanks!

@usmonster usmonster closed this Nov 6, 2013

hi i just downloaded the plugin from this url:https://github.com/taitems/jQuery.Gantt/blob/master/js/jquery.fn.gantt.js

and this error keeps happening, I ventured to try to correct the error, and I found myself on the line 330 is the if statement that the number of rows is responsible to paint.
The problem is that in this condition, "adding" varibles strings so does not work correctly the if condition, it resolved as follows:

if (i >= element.pageNum * parseInt(settings.itemsPerPage) && i < (element.pageNum * parseInt(settings.itemsPerPage) + parseInt(settings.itemsPerPage)))

but this genre a new error in the row of the year I paint the temporal timeline, someone could tell me how to fix this error?
thanks

Collaborator

usmonster commented Feb 22, 2014

@RafaelVRam thanks for finding this again. I was never able to see the bug. Can you make an example JSBin or JSFiddle to show what happens with the current code?

@smb smb added a commit to sb-wrk/jQuery.Gantt that referenced this issue Jan 11, 2016

@smb smb fix #2 f4caf5b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment