New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support closeOnOutsideClick for touch devices #14

Merged
merged 1 commit into from Jul 18, 2015

Conversation

Projects
None yet
2 participants
@slorber
Contributor

slorber commented Jul 16, 2015

In my own experience just closing on click is not enought because this forces the user to "tap" the screen, and sometimes on mobile apps there's not so much blank space where a tap does not trigger an action, leading to bad UX

User starting to scroll outside the portal should rather trigger portal closing for example

Support closeOnOutsideClick for touch devices
In my own experience just closing on click is not enought because this forces the user to "tap" the screen, and sometimes on mobile apps there's not so much blank space where a tap does not trigger an action, leading to bad UX

 User starting to scroll outside the portal should rather trigger portal closing for example

tajo added a commit that referenced this pull request Jul 18, 2015

Merge pull request #14 from slorber/master
Support closeOnOutsideClick for touch devices

@tajo tajo merged commit 688c371 into tajo:master Jul 18, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@tajo

This comment has been minimized.

Owner

tajo commented Jul 18, 2015

Nice. Thank you!

tajo added a commit that referenced this pull request Jan 12, 2016

Merge pull request #14 from slorber/master
Support closeOnOutsideClick for touch devices
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment