From 4671c8ebeec637b80feeb67f947e96766ef91f63 Mon Sep 17 00:00:00 2001 From: Gergely Nemeth Date: Mon, 28 Oct 2019 15:21:47 -0700 Subject: [PATCH] fix(rtl): correctly picking up new values --- ...-test-ts-dnd-the-thumb-to-right-1-snap.png | Bin 2104 -> 2036 bytes ...-test-ts-dnd-the-thumb-to-right-2-snap.png | Bin 0 -> 2104 bytes e2e/rtl.test.ts | 5 +++-- examples/Rtl.tsx | 4 ++-- src/Range.tsx | 2 +- 5 files changed, 6 insertions(+), 5 deletions(-) create mode 100644 e2e/__image_snapshots__/rtl-test-ts-dnd-the-thumb-to-right-2-snap.png diff --git a/e2e/__image_snapshots__/rtl-test-ts-dnd-the-thumb-to-right-1-snap.png b/e2e/__image_snapshots__/rtl-test-ts-dnd-the-thumb-to-right-1-snap.png index e727b04b8f4dc2dab8f69bb84dfd93eeccdb994b..a13570e903af2a0b91b8f1d7ff13a7664489a891 100644 GIT binary patch literal 2036 zcmeH|SyWS36oyZNAPrI+NEV<#QA;U=K?EvbLs7y|B@2{5K!(U5APLGOpg;f%YQ&<_ zf($m*)ainefCNlTr4cX%J8vAq0zH${2dn;idMus}FrS_nf`MUDS$wio9xK5I>&1kWeE zQXYK$M$vDnnjI5XiUmQ$BqGwV^U1q}q0w5F%D8 zrZW5`b?xP?NTAc0h==rRAqX~;*hb;0&vR~*iA1!&q%Ga;+*1k%6DE5)$bf}*Xh|mZ zW|+o>dJ~D$>g7c%dUNFm!ZAlPb8}{5Rg>}J74(QV6SV4brG-QyKD3-o!VXcw@m^2l zGgkCy^hp`@2@W=A4MdxQutF=L0DL_vz_FdBy#8xg5d4bCe&Cs;7R3`EwTsXHn}h(4p0oewvSb*X^I;|ugg7z*3dIFwfqtR)IZ8( zvLmk|qM{5`^RSFNT%SFlttj~xT0)G)TX=c9zfjM}#VtJES&_iK1{}QzUzeAi zZCp`N5tF+UIMl00RAZ^eVzGF7ZqCTSz#yiy;xW|(fQ#>7L4GV;-Fua=5WX&h7MUP_ z_xvv-4{tK;;daZ?a&tePkV`kO0=|~@Z{@?G{BD2CGPciv6xWD?#SIb|hTM+W{=3f9 zn!T1~O#=2yF+VX+W7zeLApR|)rySxckIPw9*@{G>XdJ`G%S+-^D=^y5NyB+~2!z5tSj<@%qWD<2aq`--N3phF z3}z*2DJCben>R;BMvjh*SUheh;j)-4h3A$e$;4m|uCzURU3`3eQbBKNt*S`_OmCE_ zH9gw)>%m_khz>zIQSB3=kE*+Z5d+1+i(LIWRVG)1M@upp-xe0$y*7Sd1$-0829q-96`SshKP8r~0DWk1It=5&Y9SLhv}`Qq+Hm zQ`Ez{qhc3ogOWr0i)Wv0v>`@HkvU4fE^NqsgrIy2FSwqv4hfi2G&bT?3EQLcxwD2= y>(F)SzTZw7|4GI_oBwxy{?GbrlKxdCp3?R=4#nOOP?q3l9Qff0UaVc@!ruT2i6lt? delta 1424 zcmV;B1#kNF54aGJF<$aXL_t(|obBCDZWC!5z~Q(4*+GbrI%*bV!Fuk{+c`tuU`{nR zm@~|FuE7!{glGvVfjF+JUZAoH$8IvyZ&G~K&m&o78;n0z`RT2%D%CiSV*mhmri{E_!G{B)i{pdJYU)rQ0I=v&ncS;768SXhtqLboqC-5++#U4 zwL0~f|M@tMB5NfC768SYN7OJ3hvW48II^BPu;xKkf7f-?b$xg~9jCYwS?eIM04UO_ ziPbO+(f9q~Sl4wlO>=L8HUIo$Id|%>@B8Tc{;;mP{(8rx>Bu?=EC7l(kE_1#V;skL z{``3~O|$gUPP)6hi<_I9XxpzphNsEZ{JAMs+2k?+#X2>;y1ToJ?RNXa##KZ_*LBe} zP3-skf5XJ>)Rc{K2`m7LbG%`FimUy8AN&12Hk-|Yt9zKuX7f#84Z{!-KgJc0{CNTk zfMT7RV3lGR1{16m6IcKgZGOez6f33J@AvnvcASWX? z*Fj(bP_+3e!jh&}=kC?TItVNPiuOl$Z2!^Oe|xoF_Fw_93Z;e0sT-xT9wt}-6zlj` z-;@?9rLC8TGrz0RSWuSO5UY1Qq~5vc)#JfBg6{-oAYsx3{-TEdhW+ ze;wZiz3=@#`;}_~q}*q|Ra!EO7+@JeIe=jq&gQ?iTz0#R5xQ0RWHb?QhH7C4aHN+HSW? zeKi2^7jX5{a;I1q3#_ZFE0F~NJc?-#f7VhK+vI+Ec^Q|NmrH#;00leV+`ilG;`a77 zK7ana^wJ*e=f73)&wp&=*|Tjtd-g0gn@x0G7fsVdU4NZ_RFzHcrE;4F0Dxoy3jiRQ zzybhBCa?eik}bB$9RPlGZQI7HSFgT#uj{&nRzpby766>lwryNpT`j!~3gi?alQ97q ze+%;a2G_}L8UQHP6eq{WQk1q{9?k>{fK{lfDypiAVHlQP%Kv0qx7b=2fdxR(=7CaG zRova(Exn`%sj4dKx)xU}C9nV}+7u{tT}NHl(KJn5Utcf1tnd2t>C<7&rdaDEumC91 zJV>U%YMLgRril+9KE!UfTX==%U0+|vfA#fsG);4FiY2nv!6tVAigrA`YTGt$Z*Swx zn>Vr9Y~teLB8Fi&?9Cd-@yXXWt#KU3`10jTjN=&F?KaxBy*I_0e~xkqEC7l%KeaXm zR@Zfhh}!LTadUGMecwml_c4y+;qeq}n~wAN>$)yBn@x0G7j4^~oMKTvfdxQuf2yiF zMAAH9jsvQ$>uB3H`o5207@jn+rnQ}#uytK`FR<#mK75Aq2`m7Lb!tj9e?7(3Jg_33 z?lj@43ET8&+tvhY#RL`r#hU`=`1LRhhf{;|z>0YM$ePFBsY%v+a&>$aq0lOyzyhF1 z(`mwaj7*U=h08Du(YEcqQ-e=Af5DoL^T?XV)^QxN4gw2+;vI*~IF5&__D=1)ddf}i z^VjDd$NvY)SB+17y($1CI{q;>pHe;b#OjZn3n{l|SSNu6z$%;zt?#|}6i!XEzV~-1 zo4^8KRZ9D@Cal)U9xMP><)Ojym?0*b5Lf{GC5a#&lj}kO0FntT0DxoylW7NalOPAa elOP9a7X1$6pznQ0Md~F00000shs|K|VgSJPmi^eTus1*hyU9dBQdY)+A z#-x~y#wCqGQOHaTO)jxaV{#ptVfLH-ZTBzO-Cxc*&*z-;dEWD$_x+rc<>l$RT|r#| z0I=QN&BYr4m>)Fm+$smP7Nw;PP$v`X?dlAuy_z!sY*}!3aXOno5saRWRJyF*I!50Z za>~rN4OO|=mNfTjUS0 z(#Ub}`7%>eYcyz03ZieTTbtuWxG|DO!idzb-GU``BP zYdMEPt+lu(%Bp~>1+~7VBA!_%+Z`iAQ(y(g8eJ(M)J|lQT1wcuPuOMZg`PODs??hf zvBt9t7*_V0CbC`|lI2wZlaw(K?N^*cSsMwqv8=aUE|Pw+ChCOgL3x>E*SCkaWlStd ztm{f_X;V%p4)!e;mte2;@b}&4`1@$UpuZw(@bI=i(fXJl2Wx?hjk;zjl?2S|HXr9~uWd;6|$9Xj^pNfKd-sX@gg%-tY0Ii>17N`62&B8B-u*|_YTP$Z(pQ8H`l zh9-A7<`biuyoP1NG+DO?j5S6$P8b=lCtnPo-zxW=o*QIt0$*{B50~~0U9Ie%e$juSXNV*akLGV3eT#>?uLxeMbVK>J-Q;sJ;O^k$f8DScA;6o zp(i>g_tU_K90<1XJwrUj$j(+wW5(N@*a~i*!pHz!2qox(n0KsWBA((Ut4H29<22}W zx`(Mus*Cz#o)^J~lebl+9nUi;knTIoo~G)}8joHVYRh4l*w1;qcC)-nPFI9FFkmYm zWU;*OH27=x$||O!eycR9tRw`g75H~cFP^8rJFl7sckG)=^G2aYMn_E<54KcP8qGGU z_!{d$N*-1=z@lBz97t&w0s_n!)xx! zOh}(b2L!N|mp64!(5qv&>Bj>?oE;;Si-?Shn&=^0JsJuhA0OAb5orCXN1Zj_#j&c1 z)?}?NeDuhfP~!>^!wn28CJ9g6l(eNoJp%5-!DeI*3*w?7<1F=u&LE$$n0mXFSZgAB%LG{ufm<3 z9D_~XbN`J|X)ElW+rZ`Li8-h8Ez@5@j&Be!&Rjoj(?%jLLTlO4nsqxM!;NcYys{={ zRIPXlnv%MabBmm5ZI*OPw{Pxg9K#6c+HM>{lzJaqeleRzQ8c7q@;jIYZ#AMQ)(9CQ zWl!YeW>LHWxfO;%ofJRPuV!~?n*g7W_uCeV_Un^&`2mSu);{gqd}o>eN3s8RKWOVa YChiGwt|w;opsxUMKjG;@b;ex#6TeJZ)c^nh literal 0 HcmV?d00001 diff --git a/e2e/rtl.test.ts b/e2e/rtl.test.ts index 32ac0a6..924081e 100644 --- a/e2e/rtl.test.ts +++ b/e2e/rtl.test.ts @@ -14,17 +14,18 @@ import { await addFontStyles(page); await page.evaluate(() => { document.dir = 'rtl'; - }) + }); }); test('dnd the thumb to right', async () => { await trackMouse(page); + expect(await page.screenshot()).toMatchImageSnapshot(); await page.mouse.move(300, 80); await page.mouse.down(); await page.mouse.move(460, 80); await page.mouse.up(); await untrackMouse(page); const output = await page.$('#output'); - expect(await page.evaluate(e => e.textContent, output)).toBe('20.4'); + expect(await page.evaluate(e => e.textContent, output)).toBe('60.2'); expect(await page.screenshot()).toMatchImageSnapshot(); }); diff --git a/examples/Rtl.tsx b/examples/Rtl.tsx index c9160c7..0a6a53e 100644 --- a/examples/Rtl.tsx +++ b/examples/Rtl.tsx @@ -2,7 +2,7 @@ import * as React from 'react'; import { Range, getTrackBackground } from '../src/index'; const STEP = 0.1; -const MIN = 0; +const MIN = 50; const MAX = 100; class Basic extends React.Component { @@ -10,7 +10,7 @@ class Basic extends React.Component { values: [50] }; render() { - return ( + return (
{ } // invert for RTL if (rtl) { - newValue = max - newValue; + newValue = (max+min) - newValue; } if (Math.abs(values[draggedThumbIndex] - newValue) >= step) { onChange(