Skip to content

Fixes for modern readline #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 22, 2022
Merged

Fixes for modern readline #120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9259532
Fixes for modern readline
kdm9 May 24, 2022
a464e1d
ohne subshell
kdm9 May 24, 2022
d6a048b
pyproject: mark ipykernel as dependency
kdm9 May 30, 2022
a4c81c9
Remove TERM_PROGRAM as it may cause a hang
kdm9 Jun 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions bash_kernel/kernel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,9 +105,12 @@ def _start_bash(self):
finally:
signal.signal(signal.SIGINT, sig)

# Disable bracketed paste (see <https://github.com/takluyver/bash_kernel/issues/117>)
self.bashwrapper.run_command("bind 'set enable-bracketed-paste off' >/dev/null 2>&1 || true")
Copy link
Collaborator Author

@kdm9 kdm9 Jun 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hcz and, do you get any output if you redirect this to some file rather than /dev/null? If you edit this file in a testing venv/conda env, perhaps try commenting out the line below (TERM_PROGRAM=...) to see if that's the cause.

# Register Bash function to write image data to temporary file
self.bashwrapper.run_command(image_setup_cmd)


def process_output(self, output):
if not self.silent:
image_filenames, output = extract_image_filenames(output)
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ module = "bash_kernel"
author = "Thomas Kluyver"
author-email = "thomas@kluyver.me.uk"
home-page = "https://github.com/takluyver/bash_kernel"
requires = ["pexpect (>=4.0)"]
requires = ["pexpect (>=4.0)", "ipykernel"]
description-file = "README.rst"
classifiers = [
"Framework :: IPython",
Expand Down