Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bogus flit init tests #229

Merged
merged 2 commits into from Nov 12, 2018
Merged

Fix bogus flit init tests #229

merged 2 commits into from Nov 12, 2018

Conversation

@wimglenn
Copy link
Contributor

wimglenn commented Nov 3, 2018

Previously, these were only passing because flit itself has a pyproject.toml and LICENSE file in project root. If you assert on contents you would see for example email was actually thomas@kluyver.me.uk and not the expected thomas@example.com.

wimglenn added 2 commits Nov 3, 2018
…f has a pyproject.toml and LICENSE file in project root
@takluyver takluyver merged commit 80c0d38 into takluyver:master Nov 12, 2018
4 checks passed
4 checks passed
codecov/patch Coverage not affected when comparing e4d5833...80c0d38
Details
codecov/project 84.51% remains the same compared to e4d5833
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@takluyver

This comment has been minimized.

Copy link
Owner

takluyver commented Nov 12, 2018

Good catch

@wimglenn wimglenn deleted the wimglenn:flit_init_tests branch Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.