Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better validator for home-page field #230

Merged
merged 1 commit into from Nov 12, 2018

Conversation

@wimglenn
Copy link
Contributor

wimglenn commented Nov 3, 2018

  1. home-page is optional since #173 , so flit init shouldn't require that
  2. flit init shouldn't accept a home-page value for which flit build will refuse to build
@wimglenn wimglenn force-pushed the wimglenn:homepage_validator branch from 23ef400 to cc7f85f Nov 4, 2018
@takluyver takluyver merged commit 330c5e7 into takluyver:master Nov 12, 2018
4 checks passed
4 checks passed
codecov/patch 100% of diff hit (target 84.51%)
Details
codecov/project 84.6% (+0.08%) compared to e4d5833
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@takluyver

This comment has been minimized.

Copy link
Owner

takluyver commented Nov 12, 2018

Thanks!

@wimglenn wimglenn deleted the wimglenn:homepage_validator branch Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.