Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for Python 2 support a little more thoroughly #232

Merged
merged 2 commits into from Nov 12, 2018

Conversation

@zenbot
Copy link
Contributor

zenbot commented Nov 10, 2018

Fixes #227.

@takluyver

This comment has been minimized.

Copy link
Owner

takluyver commented Nov 10, 2018

Thanks! This is a bit of code that's lingered from basically the first rough draft of Flit, and it's long overdue some improvement.

("3", False),
(">= 3.7", False),
("<4, > 3.2", False),
('>3.4', False),

This comment has been minimized.

Copy link
@takluyver

takluyver Nov 10, 2018

Owner

Can we have a test for the pattern people often use to indicate 2.7 or 3.x support, like >=2.7, !=3.0.*, !=3.1.*, !=3.2.*.

This pattern is commonly used to indicate Python 2.7 or 3.x support.
@takluyver takluyver merged commit 8b9d2af into takluyver:master Nov 12, 2018
4 checks passed
4 checks passed
codecov/patch 100% of diff hit (target 84.51%)
Details
codecov/project 84.54% (+0.03%) compared to 688f007
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@takluyver

This comment has been minimized.

Copy link
Owner

takluyver commented Nov 12, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.