Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for building sdists in Mercurial repos #233

Merged
merged 1 commit into from Nov 13, 2018

Conversation

@zenbot
Copy link
Contributor

zenbot commented Nov 13, 2018

find_repo_root's parent-directory-walking behaviour doesn't behave quite as expected when called with a relative path; if called in any directory except the root of the repo it would return None, which calling code did not expect.

find_repo_root's parent-directory-walking behaviour doesn't
behave quite as expected when called with a relative path;
if called in any directory except the root of the repo it
would return None, which calling code did not expect.
@takluyver

This comment has been minimized.

Copy link
Owner

takluyver commented Nov 13, 2018

Seems reasonable, thanks!

@takluyver takluyver merged commit 8498aa7 into takluyver:master Nov 13, 2018
4 checks passed
4 checks passed
codecov/patch 100% of diff hit (target 84.58%)
Details
codecov/project 84.64% (+0.06%) compared to cccc0c9
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.