Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make Author-email field optional #289

Merged
merged 1 commit into from Nov 4, 2019

Conversation

@wimglenn
Copy link
Contributor

wimglenn commented Oct 24, 2019

The core metadata spec says it should be optional https://packaging.python.org/specifications/core-metadata/#author-email

Related: #236

Anecdotally, I've seen people confused about what to do when they don't want a public email associated (currently they can only use flit by entering a fake email address there)

@okken

This comment has been minimized.

Copy link
Contributor

okken commented Nov 3, 2019

I'd love to see this merged.
I currently put in a fake email during init and replace it with an empty string later.

@@ -234,7 +234,7 @@ class Metadata:
def __init__(self, data):
self.name = data.pop('name')
self.version = data.pop('version')
self.author_email = data.pop('author_email')
self.author_email = data.pop('author_email', None)

This comment has been minimized.

Copy link
@takluyver

takluyver Nov 4, 2019

Owner

Let's handle this like the other optional fields - remove this line, and set author_email = None on the class.

@takluyver

This comment has been minimized.

Copy link
Owner

takluyver commented Nov 4, 2019

Thanks, this looks OK apart from one minor change. Unfortunately my recent reorganisation has caused a merge conflict that github can't resolve. Do you want to resolve that? I'm happy to fix it, as it was me who broke it.

@wimglenn

This comment has been minimized.

Copy link
Contributor Author

wimglenn commented Nov 4, 2019

Hi Thomas, I’ll leave it in your capable hands. Cheers!

@takluyver takluyver merged commit ce74009 into takluyver:master Nov 4, 2019
4 checks passed
4 checks passed
codecov/patch 100% of diff hit (target 84.88%)
Details
codecov/project 84.89% (+0.01%) compared to 7f1f894
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@wimglenn wimglenn deleted the wimglenn:optional_author_email branch Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.