Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow underscore for Python 2 identifiers #305

Merged
merged 1 commit into from Jan 2, 2020

Conversation

@onurguzel
Copy link
Contributor

onurguzel commented Dec 24, 2019

I have added the missing underscore character in the regular expressing for Python 2 isidentifier() check.

@takluyver takluyver merged commit 3380490 into takluyver:master Jan 2, 2020
4 checks passed
4 checks passed
codecov/patch 100% of diff hit (target 86.26%)
Details
codecov/project 86.26% (+0%) compared to 2740492
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@takluyver

This comment has been minimized.

Copy link
Owner

takluyver commented Jan 2, 2020

Thanks! Sorry I didn't say anything sooner - I was almost completely offline for Christmas.

@onurguzel

This comment has been minimized.

Copy link
Contributor Author

onurguzel commented Jan 3, 2020

Thanks! Sorry I didn't say anything sooner - I was almost completely offline for Christmas.

That's fine. Actually, I am sorry, I completely forgot about the holiday season. Now, I am waiting for a new release. :) Happy New Year!

@onurguzel onurguzel deleted the onurguzel:isidentifier branch Jan 3, 2020
@Eric-Arellano

This comment has been minimized.

Copy link

Eric-Arellano commented Jan 12, 2020

Thanks, @onurguzel for the fix and @takluyver for this great tool!

Do you know when you're planning to release this fix? I'm trying to create a Flake8 plugin and this issue is interfering with us because we need to support Python 2 for a little longer. A patch release would be appreciated when you have the time.

Thanks again for making Python packaging a better experience :)

Eric-Arellano added a commit to Eric-Arellano/flake8-pantsbuild that referenced this pull request Jan 12, 2020
We are going to end up using Flit, only need to use Poetry until takluyver/flit#305 is published.
Eric-Arellano added a commit to Eric-Arellano/flake8-pantsbuild that referenced this pull request Jan 12, 2020
We are going to end up using Flit, only need to use Poetry until takluyver/flit#305 is published.
@takluyver

This comment has been minimized.

Copy link
Owner

takluyver commented Jan 14, 2020

Flit 2.2 is out with this fix (among other changes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.