Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude option with pypi_wheel #168

Closed
ebranlard opened this issue Oct 16, 2018 · 1 comment

Comments

@ebranlard
Copy link

@ebranlard ebranlard commented Oct 16, 2018

I don't seem to get the exclude option to work with a package defined using pypi_wheel. This seems to have been implemented in #147 though.
The folder listed in the exclude statement is still shipped with the application.

Here's my test, a file Hello.py:

import numpy
def fun():
    print(numpy.linspace(0,1,2))

A file installer.cfg:

[Application]
name=hello
version=0.1
entry_point=hello:fun
[Python]
version=3.7.0
[Include]
pypi_wheels = 
     numpy==1.15.2
exclude=pkgs/numpy/tests

I'm using python 3.7 [MSC v.1914 64 bit] on windows 10, and I cloned the latest pynsist.

The exclusion works when using package=numpy instead of pypi_wheels=.

@takluyver

This comment has been minimized.

Copy link
Owner

@takluyver takluyver commented Oct 17, 2018

Yes, it should work. Can you try to dig into what's going on? Maybe add a failing test for it?

@takluyver takluyver closed this in b7e3f53 Oct 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.