Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid filename clashes in the build directory #162

Merged
merged 3 commits into from Oct 3, 2018

Conversation

@takluyver
Copy link
Owner

takluyver commented Sep 30, 2018

Fixes #156.

cc @JoshMayberry - this should do what we talked about when you try to include multiple files with the same name. If you've got time to try it out, please let me know how it goes. 馃槂

@JoshMayberry

This comment has been minimized.

Copy link

JoshMayberry commented Oct 2, 2018

Thanks so much. I will test it out on the next release of our program. :)

@takluyver

This comment has been minimized.

Copy link
Owner Author

takluyver commented Oct 2, 2018

Great! Is that likely to be soon? There are a few other recent changes, so I might make a release soon. If you're going to test it in the next couple of days, I'd love to have someone try this for a real use case before releasing Pynsist 2.2. Otherwise I'll do the release and see if anything breaks. :-)

@takluyver takluyver merged commit 7872ad2 into master Oct 3, 2018
4 checks passed
4 checks passed
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@JoshMayberry

This comment has been minimized.

Copy link

JoshMayberry commented Oct 22, 2018

We just created the next release, and I used your latest build. It fixes the problems we talked about.

@takluyver takluyver deleted the filename-clashes branch Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.