Allow timeout for AioSession to be ClientTimeout #429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we please have this feature? My application would very much enjoy user controlled timeout. Thank you, |
TheKevJames
requested changes
Mar 7, 2022
There was a problem hiding this comment.
Hi @orsinium, sorry for delays on reviewing this and thank you for the contribution! Looks like there's a potential issue here around usage in gcloud-rest-auth, but otherwise I love the idea of this changeset! 👍
TheKevJames
approved these changes
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR removes explicit wrapping of the passed timeout into
aihttp.ClientTimeout(aiohttp does wrapping on its own if needed), allowing to passaihttp.ClientTimeoutinstance astimeoutas well as anyfloat. This gives users more control over timeouts.