Implemented the onLoadingStateChanged callback #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Actually, instead of using MutationObserver, waiting for the |
vickz84259
requested changes
Mar 9, 2022
vickz84259
approved these changes
Mar 9, 2022
Collaborator
vickz84259
left a comment
vickz84259
left a comment
There was a problem hiding this comment.
The only thing I'd note is that we may need to refactor later and have a central place for the type definitions that are referenced from both Chatbox and ConversationList
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @eteeselink
We have an
onLoadingStateChangedcallback for the ChatBox and ConversationList, so that users can show a placeholder while the WebView (and the iframe) is loading.I'm using a
MutationObserverto see when the iframe is mounted, and I'm firing theloadedevent once the iframe is in theloadedstate.