Updated JS event handlers and implemented onCustomMessageAction

[bugnano]

cc @eteeselink

[vickz84259]

How is someone meant to unsubscribe from an event?

[vickz84259]

Why send an array with the action string and event object? The event object by itself already contains a property called action. So the message sent to Dart could just be: JSON.stringify(event)

[bugnano]

I did that basically to be independent from the event data structure.

But, as I already need to know the event data structure, in order to convert it to Dart, I agree that using event.action works as well.

[bugnano]

anyway, now I'm using only one handler for all the custom message actions, and using event.action to know the triggered action

[bugnano]

How is someone meant to unsubscribe from an event?

This actually is a known memory leak, but I don't think it will be that serious.

The way I envisioned it is this:

You put the actions that you want to subscribe to as keys of the mapping.

If you want to subscribe to a new custom action, you add the key to the mapping, and internally, I handle the JS to handle the subscription.

If you don't want to be subscribed anymore, you remove the key from the mapping, and it will work.

Internally the JS will still be subscribed, but no handler will be called from the Dart side.

I know it's not optimal, but I don't think it's a problem.

@eteeselink what do you think?

[eteeselink]

My Flutter-fu fails me, but I'd like to understand this.

With this code, how would someone subscribe to a custom action?

[bugnano]

My Flutter-fu fails me, but I'd like to understand this.

With this code, how would someone subscribe to a custom action?

With a mapping, as per the (already approved) docs:

onCustomMessageAction: {
  'favourite': (event) {
    print('Favourited message with id: ${event.message.id}');
  },
  'report': (event) {
    print('Reported message with id: ${event.message.id}');
  },
},

[eteeselink]

ok clear. that's delightful btw :) not sure if i already said that.