Permalink
Browse files

Fixing a few places where I had hardcoded the Save History value inst…

…ead of using the settings
  • Loading branch information...
1 parent 0720be5 commit c2741f6ba76f1096f1025f199a9ed0538feb0256 Mark Ransom committed Jan 7, 2012
View
6 src/com/andrewshu/android/reddit/threads/ThreadsListActivity.java
@@ -1001,7 +1001,7 @@ public boolean onContextItemSelected(MenuItem item) {
case Constants.OPEN_IN_BROWSER_CONTEXT_ITEM:
setLinkClicked(_item);
- Common.launchBrowser(this, _item.getUrl(), Util.createThreadUri(_item).toString(), false, true, true, false);
+ Common.launchBrowser(this, _item.getUrl(), Util.createThreadUri(_item).toString(), false, true, true, mSettings.isSaveHistory());
return true;
case Constants.SAVE_CONTEXT_ITEM:
@@ -1140,7 +1140,7 @@ public boolean onOptionsItemSelected(MenuItem item) {
url = Constants.REDDIT_BASE_URL;
else
url = new StringBuilder(Constants.REDDIT_BASE_URL + "/r/").append(mSubreddit).toString();
- Common.launchBrowser(this, url, null, false, true, true, false);
+ Common.launchBrowser(this, url, null, false, true, true, mSettings.isSaveHistory());
break;
case R.id.light_dark_menu_id:
mSettings.setTheme(Util.getInvertedTheme(mSettings.getTheme()));
@@ -1404,7 +1404,7 @@ public void onClick(View v) {
setLinkClicked(thingInfo);
Common.launchBrowser(ThreadsListActivity.this, thingInfo.getUrl(),
Util.createThreadUri(thingInfo).toString(),
- false, false, useExternalBrowser, false);
+ false, false, useExternalBrowser, mSettings.isSaveHistory());
}
};
}
View
2 src/com/andrewshu/android/reddit/user/ProfileActivity.java
@@ -1215,7 +1215,7 @@ public void onClick(View v) {
// Launch Intent to goto the URL
Common.launchBrowser(ProfileActivity.this, info.getUrl(),
Util.createThreadUri(info).toString(),
- false, false, fUseExternalBrowser, false);
+ false, false, fUseExternalBrowser, mSettings.isSaveHistory());
}
};
}

0 comments on commit c2741f6

Please sign in to comment.