Added a setting to disable saving browsing history #226

Merged
merged 3 commits into from Jan 8, 2012

Projects

None yet

2 participants

@MegaMark16

First off, I love this app. Secondly, I appreciate the reasoning behind the recent changes that some people are complaining about, and considering that this is not only a free, but also an open source app, I don't think they should be complaining. But with that being said, I think saving Reddit Is Fun browsing history to the default Browser's history without a way to turn that off is not ideal.

This pull request contains changes that add an additional setting under the General Settings section that allows you to disable saving browsing history. When unchecked this setting will revert the app back to its previous behavior of not saving Reddit Is Fun browsing history to the default Android web browser's history.

@talklittle
Owner

Thanks for doing this!

@talklittle

I think this one should use the preference

@talklittle

I think this one should use the preference

@MegaMark16

Yeah, I didn't notice that mSettings was available in context, so I took a shortcut. How does everything look now?

@talklittle
Owner

Thanks a lot I'll merge it and tweak a tiny bit.

@talklittle talklittle merged commit b9662c4 into talklittle:master Jan 8, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment