Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Fixed subreddit intent filters #243

Merged
merged 1 commit into from

2 participants

@blazeroni

The intent filter on ThreadsListActivity was missing the default category. Oddly, the intent filter on CommentsListActivity was picking up subreddit URLs instead. For the last tag, the host was being ignored and treated as reddit.com. Splitting the filter out fixed the issue.

@talklittle
Owner

Thank you. I'm merging this into master, but the next version of the app I plan to release will no longer be based on this repo. I've also rewritten intent filters.

@talklittle talklittle merged commit aa2a0d6 into from
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
Showing with 8 additions and 1 deletion.
  1. +8 −1 AndroidManifest.xml
View
9 AndroidManifest.xml
@@ -44,6 +44,7 @@
</intent-filter>
<intent-filter>
<action android:name="android.intent.action.VIEW" />
+ <category android:name="android.intent.category.DEFAULT" />
<category android:name="android.intent.category.BROWSABLE" />
<data android:scheme="http" android:host="www.reddit.com" android:pathPattern="/r/.*/" />
<data android:scheme="http" android:host="redd.it" android:pathPattern="/" />
@@ -57,8 +58,14 @@
<data android:scheme="http" android:host="www.reddit.com" android:pathPattern="/r/.*/comments/.*" />
<data android:scheme="http" android:host="www.reddit.com" android:pathPrefix="/comments/" />
<data android:scheme="http" android:host="www.reddit.com" android:pathPrefix="/tb/" />
- <data android:scheme="http" android:host="redd.it" android:pathPattern="/..*" />
</intent-filter>
+ <!-- Separate filter because when added to above filter, the host is ignored -->
+ <intent-filter>
+ <action android:name="android.intent.action.VIEW" />
+ <category android:name="android.intent.category.DEFAULT" />
+ <category android:name="android.intent.category.BROWSABLE" />
+ <data android:scheme="http" android:host="redd.it" android:pathPattern="/..*" />
+ </intent-filter>
</activity>
<activity android:name=".reddits.PickSubredditActivity"></activity>
<activity android:name=".submit.SubmitLinkActivity">
Something went wrong with that request. Please try again.