Codex/UI redesign#62
Conversation
…redit-check-lsh01d Robust token accounting and persistence warnings; add baseline-browser-mapping devDependency
✅ Deploy Preview for tera-ai ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8cda8d0ba8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (error) { | ||
| console.error('[chat_update_failed]', { userId: authorId, chatId, error }) | ||
| const errorMessage = 'Your response was generated, but we could not save this chat. Please try again.' | ||
| return { | ||
| answer: errorMessage, | ||
| sessionId: sessionId, | ||
| chatId: chatId, | ||
| error: errorMessage | ||
| } | ||
| persistenceWarning = 'We generated your response, but could not save this chat message.' |
There was a problem hiding this comment.
This change converts chat save failures into warning only, but the current caller path still checks result.error (see components/PromptShell.tsx where error is destructured and handled) and does not consume warning, so persistence outages become silent data-loss events: users see a normal answer even though the message was not stored and are never prompted to retry. Please keep a machine-readable error signal for persistence failures (or wire warning in the caller) before removing the old error return behavior.
Useful? React with 👍 / 👎.
1 participant
No description provided.