Skip to content

Codex/UI redesign #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Abdulmuiz44 merged 3 commits into from
Apr 6, 2026
Merged

Codex/UI redesign #62

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d5d6f14
Return generated answer even when chat persistence fails
Abdulmuiz44 Apr 6, 2026
6d9f89a
Merge branch 'codex/ui-redesign' into codex/fix-upgrade-modal-for-cre…
Abdulmuiz44 Apr 6, 2026
8cda8d0
Merge pull request #61 from Abdulmuiz44/codex/fix-upgrade-modal-for-c…
Abdulmuiz44 Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 7 additions & 17 deletions app/actions/generate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,7 @@ export async function generateAnswer({ prompt, tool, authorId, authorEmail, atta
const title = existingTitle || (prompt.slice(0, 50) + (prompt.length > 50 ? '...' : ''))

let savedChatId = chatId
let persistenceWarning: string | undefined

if (chatId) {
// Update existing row
Expand All @@ -185,13 +186,7 @@ export async function generateAnswer({ prompt, tool, authorId, authorEmail, atta

if (error) {
console.error('[chat_update_failed]', { userId: authorId, chatId, error })
const errorMessage = 'Your response was generated, but we could not save this chat. Please try again.'
return {
answer: errorMessage,
sessionId: sessionId,
chatId: chatId,
error: errorMessage
}
persistenceWarning = 'We generated your response, but could not save this chat message.'
Comment on lines 187 to +189
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Surface persistence failures through existing error channel

This change converts chat save failures into warning only, but the current caller path still checks result.error (see components/PromptShell.tsx where error is destructured and handled) and does not consume warning, so persistence outages become silent data-loss events: users see a normal answer even though the message was not stored and are never prompted to retry. Please keep a machine-readable error signal for persistence failures (or wire warning in the caller) before removing the old error return behavior.

Useful? React with 👍 / 👎.

}
} else {
// Insert new row
Expand All @@ -211,15 +206,8 @@ export async function generateAnswer({ prompt, tool, authorId, authorEmail, atta

if (error) {
console.error('[chat_insert_failed]', { userId: authorId, sessionId: currentSessionId, error })
const errorMessage = 'Your response was generated, but we could not save this chat. Please try again.'
return {
answer: errorMessage,
sessionId: currentSessionId,
chatId: chatId,
error: errorMessage
}
}
if (data?.id) {
persistenceWarning = 'We generated your response, but could not save this chat message.'
} else if (data?.id) {
savedChatId = data.id
}
}
Expand Down Expand Up @@ -261,11 +249,13 @@ export async function generateAnswer({ prompt, tool, authorId, authorEmail, atta
})
}

const warning = [persistenceWarning, usageAccountingWarning].filter(Boolean).join(' ') || undefined

revalidatePath('/')
revalidatePath('/history')
if (usageAccountingSucceeded) {
revalidatePath('/profile')
}

return { answer, sessionId: currentSessionId, chatId: savedChatId, warning: usageAccountingWarning }
return { answer, sessionId: currentSessionId, chatId: savedChatId, warning }
}