-
Notifications
You must be signed in to change notification settings - Fork 785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Action migration for v0.2 (.talon -> .py) #482
Conversation
825897e
to
4c2dedd
Compare
…_talon into action_migration
Use auto_lang where appropriate/missed.
what's the thinking for "_Platform Specific" as the folder name? it seemed confusing to me at first, also seems hard to say if you actually had to speak it and also prone to having to escape space depending where you're working. to me since |
It's just an old habit due to how Windows orders folders in Explorer etc, which is probably a bad idea.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i've gone through all of the changed files and made a few comments. it seems sane in general, i'm running a merged copy in my fork at the moment in it seems to be working without problem, but obviously there is a minimum amount of stuff i'm actually hitting code coverage wise. i guess the biggest problem is potentially the missing tag migrations that i noted
Thanks much for reviewing this one @fidgetingbits. |
Also some work for #322
Platform-specific apps moved to apps/platforms/ for convenience
The default app.talon / edit.talon implementations were moved into /code: