Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action migration for v0.2 (.talon -> .py) #482

Merged
merged 15 commits into from
Jul 5, 2021
Merged

Conversation

knausj85
Copy link
Member

@knausj85 knausj85 commented Jul 2, 2021

Also some work for #322

  1. Multi-platform apps are laid out (mostly) as follows:
chrome.talon # commands live here
chrome.py  # any common code support e.g. action declarations, app name defintions
mac.py # mac-specific action implementations
win.py # win-specific action implementations 
linux.py # linux-specific action implementations
  1. Platform-specific apps moved to apps/platforms/ for convenience

  2. The default app.talon / edit.talon implementations were moved into /code:

code/platforms/win/edit.py 
code/platforms/win/app.py

@knausj85 knausj85 linked an issue Jul 2, 2021 that may be closed by this pull request
@fidgetingbits
Copy link
Collaborator

what's the thinking for "_Platform Specific" as the folder name? it seemed confusing to me at first, also seems hard to say if you actually had to speak it and also prone to having to escape space depending where you're working. to me since code/ now has code/platform/win, it would be more clear if it was also apps/platform/win or maybe apps/_platform/win if the score is meant to indicate that it's not an application itself?

@knausj85
Copy link
Member Author

knausj85 commented Jul 3, 2021

It's just an old habit due to how Windows orders folders in Explorer etc, which is probably a bad idea.

apps/platform/win is probably better

lang/c/c.talon Outdated Show resolved Hide resolved
Copy link
Collaborator

@fidgetingbits fidgetingbits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i've gone through all of the changed files and made a few comments. it seems sane in general, i'm running a merged copy in my fork at the moment in it seems to be working without problem, but obviously there is a minimum amount of stuff i'm actually hitting code coverage wise. i guess the biggest problem is potentially the missing tag migrations that i noted

@knausj85
Copy link
Member Author

knausj85 commented Jul 4, 2021

Thanks much for reviewing this one @fidgetingbits.

@knausj85 knausj85 merged commit dded1d6 into master Jul 5, 2021
@knausj85 knausj85 deleted the action_migration branch July 5, 2021 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

folder structure in apps (super nitpicky, trivial thing)
3 participants