Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

talon stops responding to pops/noise after reloading the file that registers the callback #160

Closed
rntz opened this issue Nov 17, 2020 · 4 comments

Comments

@rntz
Copy link

rntz commented Nov 17, 2020

Talon stops responding to pops if you cause the file that registers the callback to be reloaded, eg. by editing it. For example:

noise.py

from talon import noise

def on_pop(active):
    print("!!! POP !!!")

noise.register("pop", on_pop)

To reproduce: Make a file noise.py in the talon user directory as above. Start Talon. Verify that popping produces a line in the log. Now, edit noise.py in some irrelevant way, for example by inserting a line of white space. Now, verify that popping no longer prints a line in the log.

Note that calling noise.noise.dispatch("pop", True) from the repl will still call the callback and print a line to the log, so the problem does not appear to be that the callback is becoming unregistered.

@jpaddison3
Copy link

#163 let

@lunixbochs
Copy link

this was fixed in latest beta

@rntz
Copy link
Author

rntz commented Feb 27, 2021

This appears to be still be an issue for me.

@lunixbochs
Copy link

Fixed again in 199, must have lost it in a merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants