From 47ae6760083764747b6c98c1a04e7966141b4e43 Mon Sep 17 00:00:00 2001 From: Talysson Date: Thu, 21 Mar 2019 15:37:41 -0300 Subject: [PATCH] Decrease complexity of function --- src/initialization/initialization.js | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/src/initialization/initialization.js b/src/initialization/initialization.js index 4852c7d..5f293a7 100644 --- a/src/initialization/initialization.js +++ b/src/initialization/initialization.js @@ -1,6 +1,14 @@ const { ATTRIBUTES } = require('../symbols'); const initializationOrderFor = require('./initializationOrder'); +function initializedValue(attrPassedValue, attrInitializer, attrDescriptor, instance) { + if(attrPassedValue !== undefined) { + return attrPassedValue; + } + + return attrInitializer(attrDescriptor, instance); +} + module.exports = function forSchema(schema) { const initializationOrder = initializationOrderFor(schema); @@ -13,11 +21,7 @@ module.exports = function forSchema(schema) { const attrDescriptor = schema[attrName]; const attrPassedValue = attributes[attrName]; - if(attrPassedValue !== undefined) { - instance[attrName] = attrPassedValue; - } else { - instance[attrName] = attrInitializer(attrDescriptor, instance); - } + instance[attrName] = initializedValue(attrPassedValue, attrInitializer, attrDescriptor, instance); } } };