Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add align_single_comments option #409

Merged
merged 3 commits into from
May 19, 2023
Merged

Add align_single_comments option #409

merged 3 commits into from
May 19, 2023

Conversation

thejcannon
Copy link
Contributor

Fixes #404 by adding a new option (as to not disrupt existing behavior) that controls whether single comments get aligned.

Copy link
Collaborator

@ia0 ia0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me modulo the small nit. Thanks for pulling this up!

crates/taplo/src/formatter/mod.rs Outdated Show resolved Hide resolved
@ia0 ia0 requested a review from panekj May 19, 2023 08:33
@thejcannon
Copy link
Contributor Author

@ia0 I can't click the big green button, so when you're ready 🚀

@ia0
Copy link
Collaborator

ia0 commented May 19, 2023

@ia0 I can't click the big green button, so when you're ready rocket

I'm ready, but we're taking a 2 approval strategy (second approver merges), see #403 (comment). The second reviewer is @panekj. It might take some time because we are new maintainers so even simple PRs may take time to review.

panekj
panekj approved these changes May 19, 2023
@panekj panekj merged commit 7eaca9c into tamasfe:master May 19, 2023
@thejcannon thejcannon deleted the fix404 branch May 19, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Smarter "align_comments" when there's only 1 comment?
3 participants