Skip to content

fix: commit pr-review-benchmark source — restores green CI on main#83

Merged
drewstone merged 1 commit into
mainfrom
fix/commit-pr-review-benchmark
May 22, 2026
Merged

fix: commit pr-review-benchmark source — restores green CI on main#83
drewstone merged 1 commit into
mainfrom
fix/commit-pr-review-benchmark

Conversation

@drewstone
Copy link
Copy Markdown
Contributor

Summary

src/index.ts has exported PrReviewAuditCase, PrReviewBenchmarkSummary, PrReviewComment, PrReviewMatchedFinding, PrReviewOutcome, PrReviewReferenceFinding, PrReviewScore, PrReviewScoreWeights, scorePrReviewComments, scorePrReviewSource, and summarizePrReviewBenchmark from ./pr-review-benchmark since the run-record refactor landed — but src/pr-review-benchmark.ts (362 lines) and src/pr-review-benchmark.test.ts (139 lines) were authored locally and never committed.

CI on main has been red on #78, #79, and #81 for this reason — a fresh clone fails typecheck on the missing module. Both files were already typecheck-clean, biome-clean, and the 5 co-located tests pass.

This PR is git add + commit, nothing else. No content changes.

Test plan

  • pnpm typecheck — 0 errors
  • pnpm exec vitest run src/pr-review-benchmark.test.ts5 / 5 passed
  • pnpm exec biome check src/pr-review-benchmark.ts src/pr-review-benchmark.test.ts — clean

src/index.ts has exported `PrReviewAuditCase`, `scorePrReviewComments`,
`summarizePrReviewBenchmark`, et al. from `./pr-review-benchmark` since
the run-record refactor landed, but `src/pr-review-benchmark.ts` and
its co-located test were authored locally and never committed. A fresh
clone fails typecheck; CI on main has been red on #78, #79, and #81.

The files were already typecheck-clean, biome-clean, and the 5
co-located tests pass. No content changes — only `git add`.
Copy link
Copy Markdown
Contributor

@tangletools tangletools left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified — restores green CI on main. src/pr-review-benchmark.{ts,test.ts} have been working-tree-only since the run-record refactor; index.ts already exports from this module so a fresh clone has failed typecheck since #78. Pure git-add, no content changes. typecheck 0, 5/5 co-located tests pass, biome clean.

@drewstone drewstone merged commit 0131754 into main May 22, 2026
1 check passed
@drewstone drewstone deleted the fix/commit-pr-review-benchmark branch May 22, 2026 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants