Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare 9.3.3 #18

Open
wants to merge 21 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@bourtemb
Copy link
Member

commented Mar 29, 2019

Update cppTango to release 9.3.3
Update TangoAccessControl to release 2.14
Update assets/README to show changes between 9.2.5a and 9.3.3
Update assets/TANGO_CHANGES for 9.3.3 with a minimal text explanation

bourtemb added some commits Mar 29, 2019

Update assets/README...
... to show changes between 9.2.5a and 9.3.3
Update assets/TANGO_CHANGES for 9.3.3
Minimal text explanation in this version.

@bourtemb bourtemb requested a review from Ingvord Mar 29, 2019

@Ingvord

This comment has been minimized.

Copy link
Member

commented Mar 29, 2019

Should we merge #16 first?

@Ingvord

This comment has been minimized.

Copy link
Member

commented Mar 29, 2019

I would change rest-server to 1.9 as well

@bourtemb

This comment has been minimized.

Copy link
Member Author

commented Mar 29, 2019

Good question... I missed that one...

bourtemb and others added some commits Mar 29, 2019

@Ingvord

This comment has been minimized.

Copy link
Member

commented Mar 29, 2019

There is a bunch of changes in the README. Maybe we should extract them to assets/CHANGES_LOG file or merge it with TANGO_CHANGES?

@bourtemb

This comment has been minimized.

Copy link
Member Author

commented Mar 29, 2019

There is a bunch of changes in the README. Maybe we should extract them to assets/CHANGES_LOG file or merge it with TANGO_CHANGES?

I think there is a big work to be done to harmonize all these files and to make them up to date.

Some sections in the README file are overlapping what is/should be in other files.
I think all the installation instructions should be in the INSTALL file (which could be upgraded to INSTALL.md).
All the Changes should be in a separate file too.
It looks like there are different kinds of changes which were listed before: the release versions of the different SW parts and the bugs and changes in C++ Tango library.
There was not much information about the bugs and changes in other SW (Astor, JTango,...).

The questions are:
Do we change that?
How do we organize that?
What kind of information do we want to provide to the user?

I think there is a big work to be done to ensure the content of these files is up to date.

I guess it should not be too complicated to generate automatically a file from assets/distribution.properties which would be listing all the different versions used for the different provided Tango SW components.

About the Changelog, I am not sure about the level of details we would provide here...
If we provide some details, do we do it for the changes in all SW components, not only cppTango?

I guess it would be good to provide RELEASE NOTES too.
Again, we need to agree on the level of details we provide.

@Ingvord

This comment has been minimized.

Copy link
Member

commented Mar 29, 2019

From my experience in such aggregated distribution the best is to refer to every particular repo aka README, CHANGE_LOG, RELEASE_NOTES etc individually via a link.

While here to provide an info on migration e.g. what needs to be done to ensure 9.2.5a -> 9.3.3 migration (possibly not much), but if have such an info for each Tango release it is much more convenient for users to track what needs to be done to migrate from Tango 7.1.2 (arbitrary number) to 9.3.3

I agree a discussion would be helpful

@Ingvord Ingvord referenced this pull request Apr 1, 2019

Open

Prepare release 9.3.3 #543

14 of 18 tasks complete

bourtemb added some commits Apr 2, 2019

Update to latest available release versions
Update Jive to          Release 7.21
Update ATK to           Release 9.3.2
Update AtkPanel to      Release 5.8
Update Astor to         Release 7.2.4
Update JSSHTerminal to  Release 1.13
Update Pogo to          Release 9.6.18
Update TangoDatabase to Release 5.9
Update tango_admin to   Release 1.14
Fix missing separator error in common_target.opt
Fix the following error (a tab was missing):
common_target.opt:166: *** missing separator.
Update build.xml
Use copy ant task instead of deprecated copydir task
Cleanup POGO (#20)
Remove obsolete POGO templates
Remove pogo-6
@mliszcz

This comment has been minimized.

Copy link

commented Apr 23, 2019

Hi @bourtemb, @Ingvord

CC @piogor

What is the current status of 9.3.3? Have any critical issues been found?

There were no issues reported in kernel in last month (at least there's nothing new on github).
In source distribution we have #24 and #25 - root cause is known and possible corrections were proposed.
What about #21, #22 and #23 - do you plan these enhancements for 9.3.3?

We plan to include Tango 9.3.3 in Tangobox 9.3. I'm just wondering whether we could use this branch (prepare-9.3.3) and patch #24/#25 manually or should we wait for an official release.

@bourtemb

This comment has been minimized.

Copy link
Member Author

commented Apr 23, 2019

Hi @mliszcz,

I'm just coming back from holidays. I didn't have time yet to comment the PRs or issues you created.

No big issue were reported indeed.
I think there is still quite a lot of work to be done on the Tango distribution to release it.
We should definitely integrate #24 and #25.
I think we should also solve #21 and #23 at least.
#22 would be great too because it would avoid to generate a liblog4tango library which should no longer exist.
There is a big work to be done to update and cleanup files like the assets/README assets/TANGO_CHANGES and assets/INSTALL files.

@Ingvord

This comment has been minimized.

Copy link
Member

commented Apr 23, 2019

Hi, @mliszcz , @bourtemb ,

Here is my 50 cents:

#24, #25, #21 - must be included in 9.3.3 before release.

#23 I am not sure, maybe if it won't break anything should be added as well.

#22 will require considerable amount of manpower (as per my experience with #8) so probably will be done in the next release, as well as other "big work" on assets.

@mliszcz

This comment has been minimized.

Copy link

commented Apr 23, 2019

Hi @bourtemb, @Ingvord

Thank you guys for your inputs. I'll submit a PR for #24 and #25 still today.
If no one will take care for #21, I may try to take a look next week - depends whether we will have spare cycles at S2Innovation.

PS. Reynald, I hope you had a great holiday!

mliszcz and others added some commits Apr 23, 2019

Ingvord and others added some commits May 3, 2019

@@ -22,7 +22,7 @@ dbbench-ver=1.3
jssh-terminal-ver=1.13
log-viewer-ver=2.0.5
pogo-ver=9.6.18
rest-server-ver=1.9
rest-server-ver=1.11

This comment has been minimized.

Copy link
@bourtemb

This comment has been minimized.

Copy link
@Ingvord

mliszcz and others added some commits May 14, 2019

Merge liblog4tango into libtango (change to convenience lib) (#30) (#31)
Change log4tango into a libtool convenience library.
liblog4tango.so is no longer generated, but log4tango objects are still compiled and are now linked into libtango.so
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.