This repository was archived by the owner on Jul 8, 2022. It is now read-only.
Remove fallback snprintf implementation #659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
t-b
force-pushed
the
remove-fallback-snprintf-implementation
branch
from
3565e1f to
f85e6a9
Compare
mliszcz
reviewed
Mar 16, 2020
t-b
force-pushed
the
remove-fallback-snprintf-implementation
branch
from
f85e6a9 to
f1d82b7
Compare
Since the default C++ version was raised to 11 we now know that we have a working snprintf solution. Therefore we can drop the alternative implementation which was not touched in 18 years. This also makes LOG4TANGO_HAVE_SNPRINTF obsolete, it is therefore removed.
t-b
force-pushed
the
remove-fallback-snprintf-implementation
branch
from
f1d82b7 to
8f2218e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the default C++ version was raised to 11 we now know that we have a working snprintf solution.
Therefore we can drop the alternative implementation which was not touched in 18 years.