Couple of tiny updates to Makefile (for android) and iOS readme. #1833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matteblair
reviewed
Jul 7, 2018
platforms/ios/README.md
Outdated
| This will generate and compile an Xcode project for the Tangram iOS framework and demo application. To run/debug the demo application, open the projects in the iOS Xcode workspace: | ||
| This will generate and compile an Xcode project for the Tangram iOS framework and demo application. | ||
|
|
||
| Note: Above will show code signing errors as no developer team is set for the `TangramDemo` application project, however |
There was a problem hiding this comment.
Maybe the readme should just say to run make cmake-ios and the open the xcworkspace instead, since the first run will always have code signing errors. We could even have a make target that generates and then opens the workspace.
builds the xcode project and opens the tangram demo project in xcode workspace. update the documentation to use this make target
|
@matteblair Does f363f7a answer what you mentioned above? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.