Additional minor tweaks to reduce Windows XP issues

Some internal (non-security!) hash functions were using a variety of crypto providers without any thought for what the functions were actually doing.

These have all been condensed to a single provider, which should improve reliability on Windows XP.  (Some XP installs were reporting provider-related crashes, likely from running SP2 instead of SP3 - this should solve that, although no promises are made for 3rd-party library behavior under old XP versions!)

Author: tannerhelland

Classes/pdCrypto.cls

@@ -108,25 +108,30 @@ Private m_CryptoProviderHandle As Long, m_CryptoProviderID As PD_CRYPT_PROVIDERS
 Private m_HashHandle As Long
 
 'PD's default string hash function.  PD uses hashed strings for a lot of random things - session IDs, temp files, etc.
-' By default, the first 16 characters of an SHA-256 hash is used for these purposes.
-Friend Function QuickHashString(ByRef srcString As String, Optional ByVal strLength As Long = 16) As String
+' By default, the first 16 characters of the hash is used for these purposes.
+'
+'(NOTE: this function is not guaranteed to return identical results between sessions, so do not use it for
+' anything persistent.)
+'
+'(NOTE: using default settings, do not ask for a length > 16 as MD5 is used.)
+Friend Function QuickHashString(ByRef srcString As String, Optional ByVal dstStrLength As Long = 16) As String
 
     If (LenB(srcString) <> 0) Then
 
         Dim i As Long
 
         'Perform a quick hash of the input string
-        If QuickHash(PDCA_SHA_256, StrPtr(srcString), LenB(srcString)) Then
+        If QuickHash(PDCA_MD5, StrPtr(srcString), LenB(srcString)) Then
 
             'Retrieve the hashed data
             Dim hashBytes() As Byte, hashLength As Long
             If RetrieveHashedData(hashBytes, hashLength) Then
 
                 'Translate the first (strLength) bytes into a human-readable string, then return it.
                 ' (Thank you to vbForums user "dilettante" for this translation technique.)
-                QuickHashString = String$(strLength, "0")
+                QuickHashString = String$(dstStrLength, "0")
 
-                For i = 0 To (strLength \ 2) - 1
+                For i = 0 To (dstStrLength \ 2) - 1
                     If (hashBytes(i) < &H10) Then
                         Mid$(QuickHashString, i * 2 + 2, 1) = Hex$(hashBytes(i))
                     Else
@@ -147,8 +152,8 @@ Friend Function QuickHashString(ByRef srcString As String, Optional ByVal strLen
 End Function
 
 'Same as QuickHashString(), above, but operates on arbitrary binary data.  The first (n) chars of the result are
-' returned as a hex string.
-Friend Function QuickHash_AsString(ByVal ptrData As Long, ByVal dataLen As Long, Optional ByVal strLength As Long = 16, Optional ByVal cryptoMethod As PD_CRYPT_ALGOS = PDCA_SHA_256) As String
+' returned as a hex string.  (Using default settings, do not ask for a length > 16.)
+Friend Function QuickHash_AsString(ByVal ptrData As Long, ByVal dataLen As Long, Optional ByVal strLength As Long = 16, Optional ByVal cryptoMethod As PD_CRYPT_ALGOS = PDCA_MD5) As String
 
     'Perform a quick hash of the input string
     If QuickHash(cryptoMethod, ptrData, dataLen) Then

Classes/pdImage.cls

@@ -295,7 +295,7 @@ Friend Function GetUniqueID() As String
         Dim tmpString As String
         tmpString = OS.GetArbitraryGUID()
         m_uniqueHash = cCrypto.QuickHashString(tmpString, Len(tmpString))
-        If (Len(m_uniqueHash) > 12) Then m_uniqueHash = Left$(m_uniqueHash, 12)
+        If (Len(m_uniqueHash) > 16) Then m_uniqueHash = Left$(m_uniqueHash, 16)
     End If
 
     GetUniqueID = m_uniqueHash

Classes/pdTranslate.cls

@@ -504,7 +504,7 @@ Private Function GetLangFileChecksum(ByRef srcFile As String) As String
     strHashSource = srcFile & "|" & CStr(Files.FileLenW(srcFile)) & "|" & CStr(Files.FileGetTimeAsCurrency(srcFile, PDFT_WriteTime))
 
     'A dedicated crypto class handles the actual hashing
-    GetLangFileChecksum = m_Crypto.QuickHashString(strHashSource, 64)
+    GetLangFileChecksum = m_Crypto.QuickHashString(strHashSource)
 
 End Function
 

Modules/ColorManagement_ICM.bas

@@ -344,7 +344,7 @@ Public Function AddProfileToCache(ByRef srcProfile As pdICCProfile, Optional ByV
     'Profiles are quickly hashed; subsequent profile requests rely on this hash to return correct data
     If (m_Hasher Is Nothing) Then Set m_Hasher = New pdCrypto
     Dim profHash As String
-    profHash = m_Hasher.QuickHash_AsString(srcProfile.GetICCDataPointer, srcProfile.GetICCDataSize, , PDCA_MD5)
+    profHash = m_Hasher.QuickHash_AsString(srcProfile.GetICCDataPointer, srcProfile.GetICCDataSize, 16, PDCA_MD5)
 
     'Regardless of whether this profile already exists in our cache, we will return its hash value.  (This gives the
     ' caller a unique way to retrieve the profile in the future.)

Modules/OS.bas

@@ -1171,7 +1171,7 @@ Public Function UniqueSessionID() As String
         Dim tmpString As String
         tmpString = GetArbitraryGUID()
         m_SessionID = cCrypto.QuickHashString(tmpString, Len(tmpString))
-        If (Len(m_SessionID) > 12) Then m_SessionID = Left$(m_SessionID, 12)
+        If (Len(m_SessionID) > 16) Then m_SessionID = Left$(m_SessionID, 16)
     End If
 
     UniqueSessionID = m_SessionID

PhotoDemon.vbp

@@ -534,7 +534,7 @@ Description="PhotoDemon Photo Editor"
 CompatibleMode="0"
 MajorVer=2024
 MinorVer=8
-RevisionVer=110
+RevisionVer=111
 AutoIncrementVer=1
 ServerSupportFiles=0
 VersionComments="Copyright 2000-2024 Tanner Helland - photodemon.org"