Add arrow key support to Hand tool

For easier keyboard-based panning.

This commit (working with changes in the last one) should also resolve the keyboard focus issues mentioned in #468.  Thank you to @hi5 for catching and reporting!

Author: tannerhelland

Controls/pdCanvas.ctl

@@ -981,7 +981,11 @@ Private Sub CanvasView_KeyDownCustom(ByVal Shift As ShiftConstants, ByVal vkCode
 
         'Any further processing depends on which tool is currently active
         Select Case g_CurrentTool
-                    
+            
+            'Pan/zoom
+            Case NAV_DRAG
+                Tools_Move.NotifyKeyDown_HandTool Shift, vkCode, markEventHandled
+                
             'Move stuff around
             Case NAV_MOVE
                 Tools_Move.NotifyKeyDown Shift, vkCode, markEventHandled
@@ -1035,7 +1039,7 @@ Private Sub CanvasView_KeyUpCustom(ByVal Shift As ShiftConstants, ByVal vkCode A
 
         'Any further processing depends on which tool is currently active
         Select Case g_CurrentTool
-            
+                
             'Selection tools use a universal handler
             Case SELECT_RECT, SELECT_CIRC, SELECT_POLYGON, SELECT_LASSO, SELECT_WAND
                 SelectionUI.NotifySelectionKeyUp Me, Shift, vkCode, markEventHandled
@@ -1059,6 +1063,10 @@ Private Sub CanvasView_KeyUpCustom(ByVal Shift As ShiftConstants, ByVal vkCode A
 
         End Select
 
+        'Perform a special check for arrow keys.  VB may attempt to use these to control on-form navigation,
+        ' which we do not want.
+        If (vkCode = VK_UP) Or (vkCode = VK_DOWN) Or (vkCode = VK_LEFT) Or (vkCode = VK_RIGHT) Then markEventHandled = True
+        
     End If
 
 End Sub
@@ -2527,7 +2535,7 @@ Public Sub SetCursorToCanvasPosition(ByVal newCanvasX As Double, ByVal newCanvas
 End Sub
 
 Public Sub SetFocusToCanvasView()
-    If CanvasView.Visible Then CanvasView.SetFocus
+    If CanvasView.Visible And (Not g_WindowManager Is Nothing) Then g_WindowManager.SetFocusAPI CanvasView.hWnd
 End Sub
 
 Private Sub BuildPopupMenu()

Modules/MoveTool.bas

@@ -3,8 +3,9 @@ Attribute VB_Name = "Tools_Move"
 'PhotoDemon Move/Size Tool Manager
 'Copyright 2014-2022 by Tanner Helland
 'Created: 24/May/14
-'Last updated: 09/April/18
-'Last update: migrate move tool bits out of pdCanvas and into a dedicated module
+'Last updated: 22/December/22
+'Last update: add some trivial key-handling bits for the Hand tool (which is a different tool, but it has
+'             so few features that it's easier to just condense things here)
 '
 'This module interfaces between the layer move/size UI and actual layer backend.  Look in the relevant
 ' tool panel form for more details on how the UI relays relevant tool data here.
@@ -110,6 +111,32 @@ Public Sub NotifyKeyDown(ByVal Shift As ShiftConstants, ByVal vkCode As Long, By
 
 End Sub
 
+'We also cover hand tool key behavior in this module, despite it being a separate tool.
+' (There is not currently a separate hand-tool module.)
+Public Sub NotifyKeyDown_HandTool(ByVal Shift As ShiftConstants, ByVal vkCode As Long, ByRef markEventHandled As Boolean)
+        
+    'Handle arrow keys as standard scroll events.
+    If (vkCode = VK_UP) Or (vkCode = VK_DOWN) Or (vkCode = VK_LEFT) Or (vkCode = VK_RIGHT) Then
+    
+        'Set focus to the canvas (if it isn't already)
+        FormMain.MainCanvas(0).SetFocusToCanvasView
+        
+        If (vkCode = VK_UP) Then
+            FormMain.MainCanvas(0).CanvasView_MouseWheelVertical 0&, 0&, FormMain.MainCanvas(0).GetLastMouseX, FormMain.MainCanvas(0).GetLastMouseY, 1#
+        ElseIf (vkCode = VK_DOWN) Then
+            FormMain.MainCanvas(0).CanvasView_MouseWheelVertical 0&, 0&, FormMain.MainCanvas(0).GetLastMouseX, FormMain.MainCanvas(0).GetLastMouseY, -1#
+        ElseIf (vkCode = VK_LEFT) Then
+            FormMain.MainCanvas(0).CanvasView_MouseWheelHorizontal 0&, 0&, FormMain.MainCanvas(0).GetLastMouseX, FormMain.MainCanvas(0).GetLastMouseY, -1#
+        ElseIf (vkCode = VK_RIGHT) Then
+            FormMain.MainCanvas(0).CanvasView_MouseWheelHorizontal 0&, 0&, FormMain.MainCanvas(0).GetLastMouseX, FormMain.MainCanvas(0).GetLastMouseY, 1#
+        End If
+        
+        markEventHandled = True
+        
+    End If
+    
+End Sub
+
 Public Sub NotifyMouseDown(ByRef srcCanvas As pdCanvas, ByVal Shift As ShiftConstants, ByVal imgX As Single, ByVal imgY As Single)
 
     'Failsafe check only

PhotoDemon.vbp

@@ -517,7 +517,7 @@ Description="PhotoDemon Photo Editor"
 CompatibleMode="0"
 MajorVer=9
 MinorVer=1
-RevisionVer=84
+RevisionVer=88
 AutoIncrementVer=1
 ServerSupportFiles=0
 VersionComments="Copyright 2000-2022 Tanner Helland - photodemon.org"