XBM images: wrap up import support

Relates to #544.  Thank you to @manfromarce for catching and reporting.

PhotoDemon can now load XBM (X BitMap) image files without crashing.  Rather than lean on the 3rd-party FreeImage library for this format (because it crashes on XBM images for reasons unknown), I wrote my own XBM importer.  The format is ancient but relatively simple, and PD now covers it comprehensively.

I do not have plans to add export capabilities for the XBM format, but can revisit if users complain.

Author: tannerhelland

Classes/pdPSDLayer.cls

@@ -2411,8 +2411,7 @@ Private Function ExpandMonochrome(ByRef srcChannel As PSD_ChannelInfo, ByVal num
     Dim numPixelsProcessed As Long
 
     'There's not a performance-friendly way to mask flags in VB, so let's just use a byte array for clarity
-    Dim bitFlags() As Byte
-    ReDim bitFlags(0 To 7) As Byte
+    Dim bitFlags(0 To 7) As Byte
     bitFlags(0) = 128
     bitFlags(1) = 64
     bitFlags(2) = 32

Classes/pdXBM.cls

@@ -3,8 +3,8 @@ Attribute VB_Name = "ImageFormats"
 'PhotoDemon Image Format Manager
 'Copyright 2012-2024 by Tanner Helland
 'Created: 18/November/12
-'Last updated: 23/February/24
-'Last update: wire up PDF import
+'Last updated: 18/March/24
+'Last update: wire up XBM import
 '
 'This module determines run-time read/write support for various image formats.
 '

Modules/ImageFormats.bas

@@ -3,8 +3,8 @@ Attribute VB_Name = "ImageImporter"
 'Low-level image import interfaces
 'Copyright 2001-2024 by Tanner Helland
 'Created: 4/15/01
-'Last updated: 27/February/24
-'Last update: initial build of PDF import
+'Last updated: 18/March/24
+'Last update: initial build of XBM import
 '
 'This module provides low-level "import" functionality for importing image files into PD.
 ' You will not generally want to interface with this module directly; instead, rely on the
@@ -2114,12 +2114,6 @@ Private Function LoadXBM(ByRef srcFile As String, ByRef dstImage As pdImage, ByR
             'XBM images are always 1-bit
             dstImage.SetOriginalColorDepth 1
 
-            'Funny quirk: this function has no use for the dstDIB parameter, but if that DIB returns
-            ' a width/height of zero, the upstream load function will think the load process failed.
-            ' Because of that, we must initialize the DIB to *something*.
-            If (dstDIB Is Nothing) Then Set dstDIB = New pdDIB
-            dstDIB.CreateBlank 16, 16, 32, 0
-            
             'As simple 1-bit icons, XBM files obviously don't support color management!
             dstDIB.SetColorManagementState cms_ProfileConverted
 

Modules/ImageLoader.bas

@@ -872,6 +872,8 @@ Private Function GetDecoderName(ByVal srcDecoder As PD_ImageDecoder) As String
             GetDecoderName = "libjxl"
         Case id_pdfium
             GetDecoderName = "pdfium"
+        Case id_XBMParser
+            GetDecoderName = "Internal XBM parser"
         Case Else
             GetDecoderName = "unknown?!"
     End Select

Modules/Loading.bas

@@ -301,6 +301,7 @@ Public Enum PD_ImageDecoder
     id_PSDParser
     id_PSPParser
     id_QOIParser
+    id_XBMParser
     id_XCFParser
     id_WIC
     id_libavif
@@ -309,15 +310,13 @@ Public Enum PD_ImageDecoder
     id_resvg
     id_libjxl
     id_pdfium
-    id_XBMParser
 End Enum
 
 #If False Then
     Private Const id_Failure = -1, id_GDIPlus = 0, id_FreeImage = 0
     Private Const id_CBZParser = 0, id_HGTParser = 0, id_ICOParser = 0, id_MBMParser = 0, id_ORAParser = 0, id_PDIParser = 0
-    Private Const id_PNGParser = 0, id_PSDParser = 0, id_PSPParser = 0, id_QOIParser = 0, id_XCFParser = 0
+    Private Const id_PNGParser = 0, id_PSDParser = 0, id_PSPParser = 0, id_QOIParser = 0, id_XBMParser = 0, id_XCFParser = 0
     Private Const id_WIC = 0, id_libavif = 0, id_CharLS = 0, id_libwebp = 0, id_resvg = 0, id_libjxl = 0, id_pdfium = 0
-    Private Const id_XBMParser = 0
 #End If
 
 'Some UI DIBs are generated at run-time.  These DIBs can be requested by using the getRuntimeUIDIB() function.

Modules/PublicEnumsAndTypes.bas

@@ -525,7 +525,7 @@ Description="PhotoDemon Photo Editor"
 CompatibleMode="0"
 MajorVer=9
 MinorVer=1
-RevisionVer=325
+RevisionVer=331
 AutoIncrementVer=1
 ServerSupportFiles=0
 VersionComments="Copyright 2000-2024 Tanner Helland - photodemon.org"