Skip to content

Commit f142633

Browse files
committed
Adjustments > Photo filters: complete overhaul
This is one of those "if you can't beat 'em, join 'em" changes. Photo filters are literal filters that you snap over the top of a camera lens. They work by filtering (or in some cases, emphasizing) specific wavelengths of light, which allows for dramatic light capture that cannot be reproduced in post. Photoshop provides a weird mimicry of these filters in its "Image > Adjustments > Photo Filter" tool. I originally tried to outdo Photoshop by providing a much more comprehensive list of filters in PhotoDemon's version of the tool, complete with each filter's full technical name and descriptions. Unfortunately, that made this tool an extraordinary translation burden, with 70 phrases comprising nearly 400 words of text for a single esoteric dialog. (For perspective, that's more than 4% of PhotoDemon's total language file!) This was insanity, and today I finally reworked this dialog to simply reproduce the same options as Photoshop. That's the primary purpose of this tool, after all - to provide a "drop-in" replacement for Photoshop tutorials that require it. It was silly of me to overcomplicate it in the first place, and I apologize to my translators for such an overkill implementation. The new version of this tool is leaner, cleaner, and faster. While here, I reworked the algorithm to operate exclusively in the CieLAB color space, which produces a higher-quality transform than Photoshop at an even faster speed than PD's old implementation. The result is more dramatic lighting regardless of which "filter" you're applying, with especially improved results when trying to e.g. warm up a very cool photo (or cool a photo with very warm tones).
1 parent aa1d7a0 commit f142633

17 files changed

+889
-5594
lines changed

App/PhotoDemon/Languages/French.xml

+58-420
Large diffs are not rendered by default.

App/PhotoDemon/Languages/German.xml

+58-420
Large diffs are not rendered by default.

App/PhotoDemon/Languages/Indonesian.xml

+58-420
Large diffs are not rendered by default.

App/PhotoDemon/Languages/Italian.xml

+58-420
Large diffs are not rendered by default.

App/PhotoDemon/Languages/Macedonian.xml

+58-420
Large diffs are not rendered by default.

App/PhotoDemon/Languages/Master/MASTER.xml

+35-397
Large diffs are not rendered by default.

App/PhotoDemon/Languages/Polish.xml

+58-420
Large diffs are not rendered by default.

App/PhotoDemon/Languages/Simplified_Chinese.xml

+58-420
Large diffs are not rendered by default.

App/PhotoDemon/Languages/Spanish_(Mexico).xml

+58-420
Large diffs are not rendered by default.

App/PhotoDemon/Languages/Spanish_(Spain).xml

+58-420
Large diffs are not rendered by default.

App/PhotoDemon/Languages/Traditional_Chinese.xml

+43-405
Large diffs are not rendered by default.

App/PhotoDemon/Languages/Turkish.xml

+35-397
Large diffs are not rendered by default.

App/PhotoDemon/Languages/Vlaams.xml

+58-420
Large diffs are not rendered by default.

Forms/Adjustments_Photo_PhotoFilters.frm

+193-192
Large diffs are not rendered by default.

Forms/MainWindow.frm

+1-1
Original file line numberDiff line numberDiff line change
@@ -929,7 +929,7 @@ Begin VB.Form FormMain
929929
Index = 9
930930
End
931931
Begin VB.Menu MnuColor
932-
Caption = "Photo filters..."
932+
Caption = "Photo filter..."
933933
Index = 10
934934
End
935935
Begin VB.Menu MnuColor

Modules/Menus.bas

+1-1
Original file line numberDiff line numberDiff line change
@@ -385,7 +385,7 @@ Public Sub InitializeMenus()
385385
AddMenuItem "-", "-", 5, 13, 7
386386
AddMenuItem "Black and white...", "adj_blackandwhite", 5, 13, 8
387387
AddMenuItem "Colorize...", "adj_colorize", 5, 13, 9
388-
AddMenuItem "Photo filters...", "adj_photofilters", 5, 13, 10
388+
AddMenuItem "Photo filter...", "adj_photofilters", 5, 13, 10
389389
AddMenuItem "Replace color...", "adj_replacecolor", 5, 13, 11
390390
AddMenuItem "Sepia...", "adj_sepia", 5, 13, 12
391391
AddMenuItem "Split toning...", "adj_splittone", 5, 13, 13

PhotoDemon.vbp

+1-1
Original file line numberDiff line numberDiff line change
@@ -460,7 +460,7 @@ Description="PhotoDemon Photo Editor"
460460
CompatibleMode="0"
461461
MajorVer=8
462462
MinorVer=9
463-
RevisionVer=133
463+
RevisionVer=135
464464
AutoIncrementVer=1
465465
ServerSupportFiles=0
466466
VersionComments="Copyright 2000-2020 Tanner Helland - photodemon.org"

0 commit comments

Comments
 (0)