New Effects > Distort > Droste effect #364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously these complex functions were only used by one tool. Now I need to repurpose them elsewhere, so I'd prefer to keep them in their own place.
I need to profile this on another PC, as I'm worried it won't provide much benefit due to some inherent VB weaknesses (like no fmaf() and needing to drop into APIs like GetMem4)
…ation Again, I need to profile this on a different PC but I hold more hope this could provide a meaningful perf benefit on all distort and transform filters... fingers crossed
The Droste Effect has its own Wikipedia page: https://en.wikipedia.org/wiki/Droste_effect Many people probably associate the effect with the work of M.C. Escher: https://en.wikipedia.org/wiki/Print_Gallery_(M._C._Escher) PD's implementation is inspired by a Paint.NET plugin by several authors: https://forums.getpaint.net/topic/32240-droste-v11-may-8-2019/ Due to its heavy reliance on complex numbers (literal complex numbers, e.g. numbers with real and imaginary components) this will be one of the slower effects in PD, especially if you crank up the quality setting unnecessarily. But the results can be quite stunning!
Aaaargh I had high hopes for these, but alas, they didn't make a meaningful difference (and they have terrible readability compared to the functions they hoped to replace). Oh well, worth a try.
With this, I think this tool is ready to merge!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Droste Effect has its own Wikipedia page:
https://en.wikipedia.org/wiki/Droste_effect
Many people probably associate the effect with the work of M.C. Escher:
https://en.wikipedia.org/wiki/Print_Gallery_(M._C._Escher)
PD's implementation is inspired by a Paint.NET plugin by several authors:
https://forums.getpaint.net/topic/32240-droste-v11-may-8-2019/
Using the clock image from that page, here's what it looks like in PD:
...with the final result turning out quite lovely, I think. Notice how high-quality the numbers are as they approach the center - that's PD's supersampling engine at work!
Anyway, due to its heavy reliance on complex numbers (literal complex numbers, e.g. numbers with real and imaginary components) this is one of the slower effects in PD, especially if you crank up the quality setting unnecessarily. But the results can be quite stunning, so I think it's worthy of inclusion.