Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add useMemo() to useQueries() to avoid constant rerendering #2992

Merged
merged 3 commits into from Nov 24, 2021

Conversation

@alecf
Copy link
Contributor

@alecf alecf commented Nov 19, 2021

fixes #2991

@vercel
Copy link

@vercel vercel bot commented Nov 19, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tanstack/react-query/CT1UyzGmyEjfCcyFn97c1CSZqGE4
Preview: https://react-query-git-fork-alecf-alecf-usequeries-caching-tanstack.vercel.app

@codesandbox
Copy link

@codesandbox codesandbox bot commented Nov 19, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 11ae1f1:

Sandbox Source
tannerlinsley/react-query Configuration
tannerlinsley/react-query: basic-typescript Configuration

@codecov
Copy link

@codecov codecov bot commented Nov 23, 2021

Codecov Report

Merging #2992 (11ae1f1) into master (7948e7a) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2992      +/-   ##
==========================================
+ Coverage   96.41%   96.42%   +0.01%     
==========================================
  Files          45       45              
  Lines        2229     2238       +9     
  Branches      638      641       +3     
==========================================
+ Hits         2149     2158       +9     
  Misses         77       77              
  Partials        3        3              
Impacted Files Coverage Δ
src/react/useQueries.ts 100.00% <100.00%> (ø)
src/core/query.ts 100.00% <0.00%> (ø)
src/core/queryObserver.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2727c1...11ae1f1. Read the comment docs.

@TkDodo TkDodo merged commit c6906b3 into tannerlinsley:master Nov 24, 2021
8 checks passed
@tannerlinsley
Copy link
Owner

@tannerlinsley tannerlinsley commented Nov 24, 2021

🎉 This PR is included in version 3.33.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants