Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isAllRowsSelected can only be true if there are rows. #1504

Merged
merged 1 commit into from Sep 9, 2019

Conversation

@Codar97
Copy link
Contributor

commented Sep 8, 2019

When using the useRowSelect hook if you had no rows in the table isAllRowsSelected would be true as the number of selected rows equals the number of rows and a checkbox will be checked. This shouldn't be the case. You can preview the issue here.
This is just a simple fix for that issue.

@tannerlinsley tannerlinsley merged commit aea76fa into tannerlinsley:master Sep 9, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
@tannerlinsley

This comment has been minimized.

Copy link
Owner

commented Sep 9, 2019

Excellent!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.