Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(useexpanded, usepagination): omit subRows from rows #1562

Merged

Conversation

@huboneo
Copy link
Contributor

commented Oct 2, 2019

Added useExpanded 'expandSubRows' option

  • Allows consumer to opt out of adding subrows to regular rows when expanding
  • Also updated usePagination to respect this flag
  • Updated README
@codesandbox

This comment has been minimized.

Copy link

commented Oct 2, 2019

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1d24ed1:

Sandbox Source
awesome-pascal-kz1tu Configuration
@huboneo huboneo force-pushed the huboneo:expanded-sub-row-opt-out branch from 82f386e to 79adb19 Oct 2, 2019
Added useExpanded 'expandSubRows' option
@huboneo huboneo force-pushed the huboneo:expanded-sub-row-opt-out branch from 79adb19 to 1d24ed1 Oct 2, 2019
@@ -1,6 +1,6 @@
{

This comment has been minimized.

Copy link
@huboneo

huboneo Oct 2, 2019

Author Contributor

I had to push this to get the tests to pass

@tannerlinsley tannerlinsley merged commit 69e13b8 into tannerlinsley:master Oct 2, 2019
3 checks passed
3 checks passed
ci/codesandbox Building packages succeeded.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
@tannerlinsley

This comment has been minimized.

Copy link
Owner

commented Oct 2, 2019

Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.