Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: setup github actions continuous integration workflow #1578

Merged

Conversation

@codesandbox

This comment has been minimized.

Copy link

codesandbox bot commented Oct 9, 2019

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4bc1c54:

Sandbox Source
hidden-resonance-usk75 Configuration
@ChristianMurphy ChristianMurphy force-pushed the ChristianMurphy:ci/github-actions branch 4 times, most recently from 7093488 to 12ab8cc Oct 9, 2019
@tannerlinsley

This comment has been minimized.

Copy link
Owner

tannerlinsley commented Oct 9, 2019

This is neat. What's this for other than moving away from travis?

@ChristianMurphy

This comment has been minimized.

Copy link
Contributor Author

ChristianMurphy commented Oct 9, 2019

Mainly it offers an alternative to Travis, with slightly faster build start times from Windows and MacOS.

In addition this tests using npm as the package manager while Travis currently tests with yarn.
Though based on #1559 (comment)
Maybe this should be migrated to yarn as well.

@tannerlinsley

This comment has been minimized.

Copy link
Owner

tannerlinsley commented Oct 9, 2019

I have no loyalty to Travis, so if we migrated yarn as well, then I would be down with that.

@ChristianMurphy ChristianMurphy force-pushed the ChristianMurphy:ci/github-actions branch from 12ab8cc to c993d23 Oct 9, 2019
@ChristianMurphy

This comment has been minimized.

Copy link
Contributor Author

ChristianMurphy commented Oct 9, 2019

@tannerlinsley

This comment has been minimized.

Copy link
Owner

tannerlinsley commented Oct 9, 2019

Very nice! Could you add a Badge to the readme in place of the travis badge?

@ChristianMurphy

This comment has been minimized.

Copy link
Contributor Author

ChristianMurphy commented Oct 9, 2019

Sure updated badges to

GitHub Actions CI Travis CI Bundlephobia NPM Package Join the community on Spectrum GitHub Stars Twitter Followers

@tannerlinsley

This comment has been minimized.

Copy link
Owner

tannerlinsley commented Oct 9, 2019

Now the only missing piece is to remove Travis!

@ChristianMurphy ChristianMurphy force-pushed the ChristianMurphy:ci/github-actions branch from 50593f0 to 4bc1c54 Oct 9, 2019
@ChristianMurphy

This comment has been minimized.

Copy link
Contributor Author

ChristianMurphy commented Oct 9, 2019

Done, removed travis ci badge and config file.

@tannerlinsley tannerlinsley merged commit 0d7a0d5 into tannerlinsley:master Oct 9, 2019
2 checks passed
2 checks passed
ci/codesandbox Building packages succeeded.
Details
deploy/netlify Deploy preview ready!
Details
@ChristianMurphy ChristianMurphy deleted the ChristianMurphy:ci/github-actions branch Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.