Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix react-table-config.d.ts #1582

Merged

Conversation

@ggascoigne
Copy link
Contributor

ggascoigne commented Oct 9, 2019

It turns out that pulling the types directly from a package slightly
changes how visible they are to the consuming application. This makes
sense, previously we explicitly adding the react-table module to the
global namespace an so didn't need explicit imports, but now that's not
the case. So add explicit imports.

It turns out that pulling the types directly from a package slightly
changes how visible they are to the consuming application.  This makes
sense, previously we explicitly adding the react-table module to the
global namespace an so didn't need explicit imports, but now that's not
the case.  So add explicit imports.
@tannerlinsley tannerlinsley merged commit 51aa8e2 into tannerlinsley:master Oct 9, 2019
7 checks passed
7 checks passed
ubuntu-latest: node.js 10
Details
ubuntu-latest: node.js 12
Details
windows-latest: node.js 10
Details
windows-latest: node.js 12
Details
macos-latest: node.js 10
Details
macos-latest: node.js 12
Details
deploy/netlify Deploy preview ready!
Details
@dbertella

This comment has been minimized.

Copy link

dbertella commented Oct 10, 2019

Hey guys (@ggascoigne) wonderful job about adding the typings, is the documentation in tyescript.md outdated already after this? I'm still struggling to understand what's the right way to use this lib along typescript, also I guess it's worthy to link the typescript doc (if updated) in the main readme, what do you think?

@ggascoigne

This comment has been minimized.

Copy link
Contributor Author

ggascoigne commented Oct 10, 2019

@dbertella having seen your PR I think that you've got it all sorted out, but just in case I updated my simple example too: #1534

@ggascoigne ggascoigne deleted the ggascoigne:ggp/fix-typescript-override branch Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.