Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update complex types to use Array<> syntax #1587

Conversation

@ChristianMurphy
Copy link
Contributor

ChristianMurphy commented Oct 10, 2019

re-enables dtslint array type rule

re-enables dtslint array type rule
@codesandbox

This comment has been minimized.

Copy link

codesandbox bot commented Oct 10, 2019

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2a041c8:

Sandbox Source
epic-moser-gzxzq Configuration
@tannerlinsley tannerlinsley merged commit 62924de into tannerlinsley:master Oct 10, 2019
0 of 2 checks passed
0 of 2 checks passed
ci/codesandbox Building packages...
Details
deploy/netlify Deploy preview processing.
Details
@ChristianMurphy ChristianMurphy deleted the ChristianMurphy:refactor/complex-array-types branch Oct 10, 2019
Copy link
Contributor

ggascoigne left a comment

I realize that it's a bit late now, but I'd have much rather just changed the array-type definition to "array-type": [true, "array"] and moved on. The Array definition is just so wordy.

And as for any worries about consistency, there are something like 1700 hits searching for array-type over on DefinitelyTyped, and it looks like most of them just disable the rule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.