Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup size-plugin-bot #1677

Merged
merged 3 commits into from Dec 3, 2019

Conversation

@kuldeepkeshwar
Copy link
Contributor

kuldeepkeshwar commented Dec 2, 2019

Items:

kuldeepkeshwar and others added 2 commits Dec 2, 2019
@tannerlinsley

This comment has been minimized.

Copy link
Owner

tannerlinsley commented Dec 2, 2019

This was failing on the windows test, so I added a cross-env prefix. Could you pull this down and install cross-env as a dev dep?

@size-plugin

This comment has been minimized.

Copy link
Contributor

size-plugin bot commented Dec 2, 2019

Size report for the changes in this PR:

sizes-cjs Overall size: 20.5 kB

 index.js 鈴  20.5 kB (+20.5 kB 馃毇)

sizes-es Overall size: 20.3 kB

 index.es.js 鈴  20.3 kB (+20.3 kB 馃毇)

commit: 7620fdf

like it?

猸愶笍 me 馃槉

@tannerlinsley

This comment has been minimized.

Copy link
Owner

tannerlinsley commented Dec 2, 2019

Those sizes seem... off. Is it just me?

@tannerlinsley

This comment has been minimized.

Copy link
Owner

tannerlinsley commented Dec 2, 2019

Screen Shot 2019-12-02 at 9 40 12 AM

@kuldeepkeshwar

This comment has been minimized.

Copy link
Contributor Author

kuldeepkeshwar commented Dec 2, 2019

@tannerlinsley this 20.3 kB is the gzipped size. The file is not minified. bundlephobia shows 11.2 kB (MINIFIED + GZIPPED)

@stramel

This comment has been minimized.

Copy link
Contributor

stramel commented Dec 2, 2019

I think showing the minified + gzipped sizes would be more accurate to what we need. If I went in and added a bunch of code documentation, this would inaccurately reflect a large bump in size when in reality, none of that size is making it to the end user.

@tannerlinsley

This comment has been minimized.

Copy link
Owner

tannerlinsley commented Dec 2, 2019

@kuldeepkeshwar

This comment has been minimized.

Copy link
Contributor Author

kuldeepkeshwar commented Dec 2, 2019

@tannerlinsley @stramel that makes sense. currently, it is limited to gzipped/brotli size.

We do have plans to add more flexibility to how sizes are calculated.

just to give a glance of how it may look like

    file 鈴  brotli  gzip   uncompressed 
index.js 鈴  20kB    25kB    80 kB

@tannerlinsley tannerlinsley merged commit 5393ebc into tannerlinsley:master Dec 3, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can鈥檛 perform that action at this time.