Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: link to the original blog post instead of medium #1844

Merged
merged 1 commit into from Jan 10, 2020

Conversation

@lukasbuenger
Copy link
Contributor

lukasbuenger commented Jan 10, 2020

This is a very small and opinionated suggestion regarding the «Concept» section of the docs.

Just link to the original blog post and ditch Medium, especially given the fact that you already have it online somewhere else. I really don't care about their business model, but in terms of UX/UI Medium is an abomination. I tried to read the thing on my mobile on a train ride earlier today. Ugh.
Then I found the link at the top (I know, right) that points to the original post – much cleaner, no more fighting modals and whatever shitshow is going on over there – I mean, just readable fcs.

I might be unaware of some advantages you see by promoting Medium over your own, imho much better approach. If there are any, just don't mind me.

Thanks for the project and have a nice weekend!

Regards
Lukas

Edit: Just realised, it's probably not you (the lib author) who wrote the blog post. Still, I'd rather have the link point to the original thing than Medium.

@size-plugin

This comment has been minimized.

Copy link
Contributor

size-plugin bot commented Jan 10, 2020

Size report for the changes in this PR:

sizes-cjs Overall size: 23.1 kB (-3 B)

 index.js ⏤  23.1 kB (-3 B)

sizes-es Overall size: 22.9 kB (-2 B)

 index.es.js ⏤  22.9 kB (-2 B)

commit: 250fb34

like it?

⭐️ me 😊

@tannerlinsley

This comment has been minimized.

Copy link
Owner

tannerlinsley commented Jan 10, 2020

Absolutely!

@tannerlinsley tannerlinsley merged commit 5f99503 into tannerlinsley:master Jan 10, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
@lukasbuenger lukasbuenger deleted the lukasbuenger:change-blog-link branch Jan 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.