Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add New Quotes in Quotes API. #1

Closed
tanwanimohit opened this issue Oct 2, 2019 · 6 comments

Comments

@tanwanimohit
Copy link
Owner

commented Oct 2, 2019

Hello, I know you are eager to earn a hackoctober t-shirt ! this repository will help you to achieve it !

What you need to do?

  • Just Fork the Repository Click Here for Tutorial
    Repository Link : Click Here

  • Now just open quotes.db file and scroll down to the end of the file, before ]

  • Now start adding some quotes (2-3 minimum)

Here is the sample quote format

{
    "quote": "Be as you wish to seem.",
    "author": "Socrates"
}

Note : if you are adding multiple quotes don't forget to add the , commas

That's it !

Just open the PR and i will approve it ASAP. Click Here for Tutorial

Star this repo. and share it with your friends !

Thankyou.

@izulien

This comment has been minimized.

Copy link
Contributor

commented Oct 2, 2019

Do you prefer with or without category (or have zero preference)?

@tanwanimohit

This comment has been minimized.

Copy link
Owner Author

commented Oct 2, 2019

If you are adding category than it ice on the cake, else no worries!
but guys do remember to add commas as it is breaking the code!

Scapigliata added a commit to Scapigliata/quotesapi that referenced this issue Oct 2, 2019
tanwanimohit pushed a commit that referenced this issue Oct 2, 2019
Update Quotes.db
Crashn pushed a commit to Crashn/quotesapi that referenced this issue Oct 6, 2019
@ongzx

This comment has been minimized.

Copy link

commented Oct 7, 2019

#47

@ongzx

This comment has been minimized.

Copy link

commented Oct 7, 2019

#48

@ansdb

This comment has been minimized.

Copy link
Contributor

commented Oct 7, 2019

I added three quotes into the file, but I'm still waiting for you to approve it?!!!?

@tanwanimohit

This comment has been minimized.

Copy link
Owner Author

commented Oct 7, 2019

I added three quotes into the file, but I'm still waiting for you to approve it?!!!?

Hello, Thanks for contributions ! because of Conflicts, i merge 4-5 PRs daily, but anyways i have merged your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.