From 8b3a77e595b8ee328d016fa12c773e9e7299910a Mon Sep 17 00:00:00 2001 From: Jordan Harband Date: Sun, 4 Dec 2016 00:57:44 -0800 Subject: [PATCH] [Tests] fix thrower stack in node 0.8 --- test/throws.js | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/test/throws.js b/test/throws.js index bc602f0e..197ce68d 100644 --- a/test/throws.js +++ b/test/throws.js @@ -16,6 +16,14 @@ function getNonFunctionMessage(fn) { } } +var getter = function () { return 'message'; }; +var messageGetterError = Object.defineProperty( + { custom: 'error' }, + 'message', + { configurable: true, enumerable: true, get: getter } +); +var thrower = function () { throw messageGetterError; }; + tap.test('failures', function (tt) { tt.plan(1); @@ -173,14 +181,8 @@ tap.test('failures', function (tt) { test('custom error messages', function (t) { t.plan(3); - var getter = function () { return 'message'; }; - var messageGetterError = Object.defineProperty( - { custom: 'error' }, - 'message', - { configurable: true, enumerable: true, get: getter } - ); t.equal(Object.prototype.propertyIsEnumerable.call(messageGetterError, 'message'), true, '"message" is enumerable'); - t.throws(function () { throw messageGetterError; }, "{ custom: 'error', message: 'message' }"); + t.throws(thrower, "{ custom: 'error', message: 'message' }"); t.equal(Object.getOwnPropertyDescriptor(messageGetterError, 'message').get, getter, 'getter is still the same'); });