Make SKIP and TODO more verbose #98

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

Owner
rmg commented Apr 17, 2014

Makes TAP reports more useful by allowing TODO and SKIP items to be annotated.

Also includes a small tweak to make the tests pass.

Owner
rmg commented Jun 11, 2014

Rebased since one of the commits was replaced with 44f5bcf

@rmg rmg referenced this pull request in strongloop/strong-log-transformer Jun 11, 2014
Merged

Initial version #1

Owner
rmg commented Feb 11, 2015

Now with 1000% more tests!

Owner
isaacs commented Feb 12, 2015

Landed on master. Thanks!

@isaacs isaacs closed this Feb 12, 2015
@rmg rmg deleted the strongloop-forks:todo-output branch Feb 12, 2015
@rmg rmg added a commit to strongloop-forks/node-tap that referenced this pull request Feb 26, 2015
@rmg rmg don't print 'undefined' for unexplained skip/todo
Support for directive explanations was added in #98 but it was only
being applied to TAP input, which created a blank explanation if one
was not provided. The results from tap-assert did not ensure the
explanation was a string, so "undefined" started popping up for TODO
and SKIP tests.

Also make sure we preserve assert.skip explanations if they are given,
since skipped tests don't get the same "clone extra" treatment that
other asserts do.
900774a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment