runner: Support test/test-* including non-js files #99

Closed
wants to merge 1 commit into
from

2 participants

@rmg
TAP in JavaScript member

When falling back on the "is it executable" test for files that don't
end in .js or .coffee, files that are determined to be executable as
tests should be referenced by a more complete path because $CWD is
highly unlikely to be included in $PATH.

The end result is tap tests/test-* works when the tests are a mix of JS and shell scripts.

@rmg
TAP in JavaScript member

@isaacs you partially covered this with 44f5bcf. Something wrong with the test fix and the non-js pieces of this PR?

@rmg
TAP in JavaScript member

Rebased/squashed to remove conflict.

@rmg rmg referenced this pull request in strongloop/strong-log-transformer Jun 11, 2014
Merged

Initial version #1

@rmg
TAP in JavaScript member

@isaacs bump.

I've got half a dozen repos using "strongloop-forks/node-tap" in their devDependencies because of this +3/-1 change. Is there anything I can do to get this merged?

@rmg rmg runner: Support test/test-* including non-js files
When falling back on the "is it executable" test for files that don't
end in .js or .coffee, files that are determined to be executable as
tests should be referenced by a more complete path because $CWD is
highly unlikely to be included in $PATH.

Update tests to expect full paths of commands.

Update package.json to run the existing test for this scenario.
7535fd9
@rmg
TAP in JavaScript member

Now with 200% more tests! (actually, just enabled the ones that were already there but were never exercised)

@isaacs
TAP in JavaScript member

Landed on master!

@isaacs isaacs closed this Feb 12, 2015
@rmg
TAP in JavaScript member

Awesome, thanks! This will let me remove a git dep from a bunch of modules :-)

@rmg rmg deleted the strongloop-forks:allow-non-js-wildcards branch Feb 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment