Fixed css stylus source so they get compiled correctly. #169

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@vic
vic commented Mar 10, 2013

Add newlines so the css properties are not taken as if they were selectors.

Without those linebreaks, the generated css file is invalid. Including lungo.css on a rails application and trying to compile it, fails due to malformed css.

Invalid CSS after "...,video display:": expected pseudoclass or pseudoelement, was " inline-block *..."
  (in lungo.css)

Adding line breaks to separate selectors from their css properties on the stylus source has fixed this.

@vic vic referenced this pull request in tapquo/package-lungo Mar 10, 2013
@soyjavi soyjavi Release Candidate 2.1.0 e517843
@vic
vic commented Mar 10, 2013

I guess we should have an css verification step on the Gruntfile, I cached this errors cause I'm including them on my rails app assets, and they failed to compile, guess we could have a grunt task to check if the generated css from stylus is correct so this wont happen again.

@soyjavi soyjavi closed this Mar 26, 2013
@vic
vic commented Mar 26, 2013

Hey @soyjavi, any reason my two pull request got closed without further feedback on what's wrong with them or what I missed so they could be integrated? Both were no-brainers, and I would really appreciate if you could at least see the diff for this one, as I see the master branch still has the same issues. I also reviewed latest commit on the lungo-brownie build to see if perhaps you had already fixed this, but no luck.

If you look at https://github.com/soyjavi/lungo.brownie/blob/master/lungo.css#L3 you'll find the css is invalid.

So far I've liked Lungo a lot, and even when it was not easy for me to get started building from source (before the grunt 0.4 update), I believe it has a lot of potential, and have already recommended it across my coworkers (I made a little demo with Lungo brownie). So I'm all for Lungo getting more users as that would only make it better.

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment