JP Sugarbroad
taralx

  • Joined on Sep 8, 2011
Jul 24, 2016
taralx opened pull request saalweachter/autokittens#1
@taralx
Fix autotrade
1 commit with 1 addition and 1 deletion
Jul 24, 2016
@taralx
Jun 21, 2016
taralx commented on issue rust-lang/rust#27802
@taralx

I still have one major objection to #33801 that I've noted in that PR.

Jun 21, 2016
taralx commented on pull request rust-lang/rust#33801
@taralx

Since this is related to the FCP, I will reiterate that I feel strongly that Utf8CharsError should contain the failed bytes, for debugging purposes…

Jun 8, 2016
taralx commented on issue rust-lang/rust#34150
@taralx

Clippy requires nightly. :-(

Jun 7, 2016
taralx commented on issue rust-lang/rust#34150
@taralx

Honestly, a lint for truncating casts is probably worth having. I really wish there were different syntax for safe vs truncating casts.

Jun 3, 2016
@taralx

Thank you both!

Jun 2, 2016
@taralx
< causes highlighting failure
May 25, 2016
taralx pushed to master at taralx/rust
@taralx
taralx deleted branch patch-2 at taralx/rust
May 25, 2016
taralx deleted branch patch-1 at taralx/rust
May 25, 2016
May 25, 2016
taralx commented on pull request rust-lang/rust#33801
@taralx

Hm, so the spec disagrees with me. Something like ED AA 96 will end up being 3 replacement characters and not just one. :-/

May 25, 2016
taralx commented on pull request rust-lang/rust#33801
@taralx

"You're doing it wrong" isn't a very compelling argument. These are still actual use cases, and forcing people to reimplement utf8 parsing logic ju…

May 25, 2016
taralx commented on pull request rust-lang/rust#33801
@taralx

match read_byte!(EOF => return Some(Err(Utf8CharsError::IncompleteUtf8))) { vs match read_byte() { Byte(b) => ... EOF => ... Error(e) => ... }

May 25, 2016
taralx commented on pull request rust-lang/rust#33801
@taralx

Sorry, I meant this return value from fill_buf. In my opinion, we should not be retrying errors from lower layers like this -- either they wanted t…

May 25, 2016
taralx commented on pull request rust-lang/rust#33801
@taralx

The only time you error out early when a loop wouldn't is in the case of a continuation byte that represents an invalid code point. As pointed out …

May 25, 2016
taralx commented on pull request rust-lang/rust#33801
@taralx

It's not a conformance test case, but it is a test case. If you display this file with a fixed-width font, these "|" characters should all line up…

May 25, 2016
taralx commented on pull request rust-lang/rust#33801
@taralx

Some people might want to handle the case by assuming latin-1 for bad characters. Others may want to substitute U+FFFD for each bad byte rather tha…

May 25, 2016
taralx commented on pull request rust-lang/rust#33801
@taralx

It's not really different from a function read_byte that returns an enum with 3 values: Byte, EOF, or Error. What you have now still has to be matc…

May 25, 2016
taralx commented on pull request rust-lang/rust#33801
@taralx

I wonder how difficult it would be to get the contract for BufRead to prohibit this return. It's just not useful.

May 25, 2016
taralx commented on pull request rust-lang/rust#33801
@taralx

I feel like this code is more complex than simply accumulating bytes and then checking for valid u32 ranges afterwards.

May 25, 2016
taralx commented on pull request rust-lang/rust#33801
@taralx

Why Cursor?

May 25, 2016
taralx commented on pull request rust-lang/rust#33801
@taralx

This strict matching of continuation bytes will cause us to fail to properly substitute. Test cases are here: http://www.cl.cam.ac.uk/~mgk25/ucs/ex…

May 25, 2016
taralx commented on pull request rust-lang/rust#33801
@taralx

I suggest adding a test for the e282e28282 case.

May 25, 2016
taralx commented on pull request rust-lang/rust#33801
@taralx

I feel like these should contain the bytes in question.

May 25, 2016
taralx commented on pull request rust-lang/rust#33801
@taralx

I suggest calling self.description instead of repeating yourself.

May 25, 2016
taralx commented on pull request rust-lang/rust#33801
@taralx

Not e.description?

May 25, 2016
taralx commented on pull request rust-lang/rust#33801
@taralx

Why a macro instead of a simple 3-way return enum?

May 25, 2016
taralx commented on pull request rust-lang/rust#33801
@taralx

Is this really necessary? Most users of BufRead are not going to check this.