-
Notifications
You must be signed in to change notification settings - Fork 15
Support replace and upsert operations #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for your patch, please drop the first commit (Support tuples as result type) from current pull request, it's not related to "Support replace and upsert operations" |
|
Thanks a lot! Please, alseo describe new operations in README. |
d7c852c to
8b14c52
Compare
redme updated
dropped |
|
I suggest you to add tests for both engines - memtx and vinyl. See example - #4 |
|
See my last comment. After fixing it - LGTM |
|
LGTM. Seems you need to update changelog as well |
|
Change log updated |
a27d472 to
289ca3d
Compare
| end | ||
| end | ||
|
|
||
| if bucket_id ~= nil and field_format.name == 'bucket_id' then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a nit: since we already have system_fields conception, maybe it can be
function utils.flatten(object, space_format, system_values)
system_values = system_values or {}
...
if system_values.bucket_id ~= nil and field_format.name == 'bucket_id' then ...
-- if sometimes we have more system fields, it can be done in a cycle
...
endThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your patch!
Only one: please wait for new CI based on GitHub Actions is merged and rebase on it.
Then, it will be merged.
* add vinil engine for simple operation test
289ca3d to
078a812
Compare
Issue #7