From ffb837c2f84e56199072b8fbcd47dd11a1cb6afb Mon Sep 17 00:00:00 2001 From: Satbek Turganbayev Date: Mon, 8 Dec 2025 14:40:41 +0500 Subject: [PATCH 1/3] make_bucket_ref_err: call BucketRefError only once --- crud/common/sharding/bucket_ref_unref.lua | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/crud/common/sharding/bucket_ref_unref.lua b/crud/common/sharding/bucket_ref_unref.lua index aa6404c2..297d93f1 100644 --- a/crud/common/sharding/bucket_ref_unref.lua +++ b/crud/common/sharding/bucket_ref_unref.lua @@ -20,11 +20,11 @@ local M = { } local function make_bucket_ref_err(bucket_id, vshard_ref_err) - local err = M.BucketRefError:new(M.BucketRefError:new( + local err = M.BucketRefError:new( "failed bucket_ref: %s, bucket_id: %s", vshard_ref_err.name, bucket_id - )) + ) err.bucket_ref_errs = { { bucket_id = bucket_id, From 7ed64498c31887c0ce4bed3481ed0690d536ca43 Mon Sep 17 00:00:00 2001 From: Satbek Turganbayev Date: Mon, 8 Dec 2025 15:58:11 +0500 Subject: [PATCH 2/3] fix double_buckets_not_applied test, now works for get --- test/integration/double_buckets_test.lua | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/integration/double_buckets_test.lua b/test/integration/double_buckets_test.lua index 2e371ec1..326de2ca 100644 --- a/test/integration/double_buckets_test.lua +++ b/test/integration/double_buckets_test.lua @@ -221,7 +221,7 @@ local not_applied_operations = { }, get = { call = function (g, key) - return g.router:call('crud.get', { 'customers', key }) + return g.router:call('crud.get', { 'customers', key, {mode = 'write'} }) end, check_applied = function() end, check_not_applied = function(not_applied_ids) @@ -245,7 +245,7 @@ pgroup_not_applied.test_not_applied = function(g) ), 'test implemented only for 3.1 and greater' ) - t.skip_if(g.params.operation == 'get' and g.params.safe_mode == false, 'todo: rework get') + if g.params.backend == "config" then local tuples, tuples_count = {}, 1000 for i = 1, tuples_count do From 5044a6151001f353a8c592a57df48d1c154c30d3 Mon Sep 17 00:00:00 2001 From: Satbek Turganbayev Date: Tue, 9 Dec 2025 17:11:30 +0500 Subject: [PATCH 3/3] rm manual fast mode enable in select_readview_test --- test/integration/select_readview_test.lua | 5 ----- 1 file changed, 5 deletions(-) diff --git a/test/integration/select_readview_test.lua b/test/integration/select_readview_test.lua index fed95584..980f123e 100644 --- a/test/integration/select_readview_test.lua +++ b/test/integration/select_readview_test.lua @@ -2353,11 +2353,6 @@ end) pgroup.test_select_switch_master = function(g) helpers.skip_not_cartridge_backend(g.params.backend) - helpers.call_on_storages(g.cluster, function(server) - server.net_box:eval([[ - require('crud.common.rebalance').safe_mode_disable() - ]]) - end) helpers.insert_objects(g, 'customers', { {