Fix user's feedback #3751
Merged
Fix user's feedback #3751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Oct 2, 2023
xuniq
approved these changes
Oct 3, 2023
| :param string role-name: name of role to grant to user. | ||
| :param string user-name: the name of a user to grant privileges to. | ||
| :param string privileges: one or more privileges to grant to the user (for example, `read` or `read,write`). | ||
| :param string object-type: a database object type to grant privileges to (for example, `space`, `role`, or `function`) |
Contributor
There was a problem hiding this comment.
Suggested change
| :param string object-type: a database object type to grant privileges to (for example, `space`, `role`, or `function`) | |
| :param string object-type: a database object type to grant privileges to (for example, `space`, `role`, or `function`). |
For consistency, either add a period here or remove it from all other lines
andreyaksenov
force-pushed
the
fix-feedback
branch
from
fe4a74a to
1947610
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed several small issues:
box.schema.user.grant()description as they don't match with actual privileges listed in theAccess controltopic. Staging: https://docs.d.tarantool.io/en/doc/fix-feedback/reference/reference_lua/box_schema/user_grant/.